Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 6993033: Do no delete file if they exist, even if p.is_new is True. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Do no delete file if they exist, even if p.is_new is True. For a yet unknown reason, a chmod +x on a git svn checkout will set a 'A' status. Will investigate separately. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M checkout.py View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-03 21:25:46 UTC) #1
Dirk Pranke
9 years, 6 months ago (2011-06-03 22:14:16 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698