Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6993032: GpuScheduler using time quantum to avoid too many PostTasks (Closed)

Created:
9 years, 6 months ago by jbates
Modified:
9 years, 6 months ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

GpuScheduler fix: - Ganesh generates a lot of cheap GL commands, so 100 commands were executing in 50us, causing us to spin on PostTask(ProcessCommands) 60+ times per frame. This change simply tracks the elapsed time after each 100 commands - if the time is less than 2ms, it continues on to the next 100 commands. BUG=83628 TEST=trace FishIE demo with 500 fish, check that ProcessCommands is not called ~60 times per frame. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87895

Patch Set 1 #

Patch Set 2 : name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -28 lines) Patch
M gpu/command_buffer/service/gpu_scheduler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 5 chunks +43 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/mocks.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbates
split #3
9 years, 6 months ago (2011-06-03 21:28:48 UTC) #1
apatrick_chromium
LGTM
9 years, 6 months ago (2011-06-03 21:40:14 UTC) #2
piman
9 years, 6 months ago (2011-06-03 21:43:18 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698