net: followup to codereview for cl/7096014

net: followup to codereview for cl/7096014

BUG=none
TEST=net_unittests

[wtc, 2011-06-07 18:17:54]

LGTM.

http://codereview.chromium.org/6993027/diff/2002/net/base/asn1_util.cc
File net/base/asn1_util.cc (right):

http://codereview.chromium.org/6993027/diff/2002/net/base/asn1_util.cc#newcod...
net/base/asn1_util.cc:291: return false;
I think some other "return false" statements also need a
urls_out->clear() call.

Rather than adding a lot of urls_out->clear() calls, perhaps
a more systematic solution would be better.

http://codereview.chromium.org/6993027/diff/2002/net/base/asn1_util.h
File net/base/asn1_util.h (right):

http://codereview.chromium.org/6993027/diff/2002/net/base/asn1_util.h#newcode45
net/base/asn1_util.h:45: // true return value if the element was not found.
I think this will allow us to distinguish between a missing
element and a present element with length 0 (such as NULL),
right?  (Cf. your comment on lines 54-55 below.)

[commit-bot: I haz the power, 2011-06-07 20:59:17]

Try job failure for 6993027-6001 on linux for steps net_unittests, unit_tests:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...