Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6993015: Add unit-tests for SingleRequestHostResolver. (Closed)

Created:
9 years, 6 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add unit-tests for SingleRequestHostResolver. To facilitate this, moved it out of host_resolver.cc to its own set of files. BUG=84261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88006

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : sync up #

Patch Set 4 : Add a missing file #

Patch Set 5 : oops #

Total comments: 2

Patch Set 6 : replace CHECK with EXPECT #

Patch Set 7 : Try to re-upload cuz patch not applying on commit bot... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -336 lines) Patch
M chrome/browser/net/predictor.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/communicator/xmpp_connection_generator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/base/host_resolver.h View 1 2 3 4 5 6 1 chunk +0 lines, -42 lines 0 comments Download
M net/base/host_resolver.cc View 1 2 3 4 5 6 2 chunks +0 lines, -61 lines 0 comments Download
A + net/base/single_request_host_resolver.h View 1 2 3 4 5 6 2 chunks +4 lines, -206 lines 0 comments Download
A + net/base/single_request_host_resolver.cc View 1 2 3 4 5 6 5 chunks +5 lines, -27 lines 0 comments Download
A net/base/single_request_host_resolver_unittest.cc View 1 2 3 4 5 1 chunk +122 lines, -0 lines 0 comments Download
M net/curvecp/test_client.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M net/socket/socks_client_socket.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
@jam: please review content/browser/renderer_host/pepper_message_filter.cc @hclam: please review jingle/notifier/communicator/xmpp_connection_generator.h @rvargas: Please review everything.
9 years, 6 months ago (2011-06-03 03:07:17 UTC) #1
jam
content lgtm
9 years, 6 months ago (2011-06-03 05:45:13 UTC) #2
rvargas (doing something else)
LGTM! http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc File net/base/single_request_host_resolver_unittest.cc (right): http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc#newcode24 net/base/single_request_host_resolver_unittest.cc:24: CHECK(!has_outstanding_request()); nit: We could replace the checks with ...
9 years, 6 months ago (2011-06-03 18:18:19 UTC) #3
eroman
http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc File net/base/single_request_host_resolver_unittest.cc (right): http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc#newcode24 net/base/single_request_host_resolver_unittest.cc:24: CHECK(!has_outstanding_request()); On 2011/06/03 18:18:19, rvargas wrote: > nit: We ...
9 years, 6 months ago (2011-06-03 18:24:09 UTC) #4
Alpha Left Google
On 2011/06/03 18:24:09, eroman wrote: > http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc > File net/base/single_request_host_resolver_unittest.cc (right): > > http://codereview.chromium.org/6993015/diff/2010/net/base/single_request_host_resolver_unittest.cc#newcode24 > ...
9 years, 6 months ago (2011-06-03 19:37:40 UTC) #5
commit-bot: I haz the power
Can't process patch for file net/base/single_request_host_resolver.h. A +
9 years, 6 months ago (2011-06-03 19:42:17 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-03 21:19:51 UTC) #7 
Can't process patch for file net/base/single_request_host_resolver.h.
A  +

Powered by Google App Engine
This is Rietveld 408576698