Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 6992091: Compile skia's drop of the GLU tesselator into Chrome, and add the (Closed)

Created:
9 years, 6 months ago by Stephen White
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Compile skia's drop of the GLU tesselator into Chrome, and add the tesselated path renderer to the chrome build. Note that this does not actually turn on the tesselated path renderer, but makes it easier to do so later. BUG=none TEST=if it builds, you're happy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M skia/skia.gyp View 4 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
9 years, 6 months ago (2011-06-02 21:15:26 UTC) #1
jamesr
rubber stamp LGTM
9 years, 6 months ago (2011-06-02 21:16:38 UTC) #2
jamesr
Send tryjobs just to be sure this compiles everywhere, please. Don't forget the clang bots!
9 years, 6 months ago (2011-06-02 21:16:58 UTC) #3
Stephen White
9 years, 6 months ago (2011-06-02 21:21:28 UTC) #4
On 2011/06/02 21:16:58, jamesr wrote:
> Send tryjobs just to be sure this compiles everywhere, please.  Don't forget
the
> clang bots!

Thanks for the review.

I ran try jobs on win, mac, linux, win_rel, win_shared, linux_chromeos.  Don't
know why they're not showing up here.

Trying on linux_clang and mac_clang now.

Powered by Google App Engine
This is Rietveld 408576698