Issue 6992074: Remove --enable-vpn (enabled always)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6992074: Remove --enable-vpn (enabled always) (Closed)

Created:
9 years, 7 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove --enable-vpn (enabled always) Include change to CrosMock::SetNetworkLibraryStatusAreaExpectations() so that tests pass. Original CL+Review: http://codereview.chromium.org/7031040/ BUG=none TEST=ChromeOS tests pass, 'Private networks' option should always show up in ChromeOS Networks menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86703

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -29 lines)			Patch
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/cros/cros_mock.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View		1 chunk	+11 lines, -13 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

stevenjb

Last time I forgot to update the tests, ugh. Will make sure they pass before ...

9 years, 7 months ago (2011-05-25 19:16:09 UTC) #1

stevenjb

9 years, 7 months ago (2011-05-25 20:36:43 UTC) #2

Test failures are all flaky and unrelated; will push shortly.