Chromium Code Reviews| Index: src/arm/builtins-arm.cc |
| diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc |
| index 1b2b919305526b745bb7d47154b775effb993885..92b036b48ab7ef0322dd20d017649b696eb53ba8 100644 |
| --- a/src/arm/builtins-arm.cc |
| +++ b/src/arm/builtins-arm.cc |
| @@ -948,8 +948,8 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm, |
| __ b(eq, &use_receiver); |
| // If the type of the result (stored in its map) is less than |
| - // FIRST_JS_OBJECT_TYPE, it is not an object in the ECMA sense. |
| - __ CompareObjectType(r0, r3, r3, FIRST_JS_OBJECT_TYPE); |
| + // FIRST_SPEC_OBJECT_TYPE, it is not an object in the ECMA sense. |
| + __ CompareObjectType(r0, r3, r3, FIRST_SPEC_OBJECT_TYPE); |
| __ b(ge, &exit); |
|
Kevin Millikin (Chromium)
2011/05/26 13:30:10
Not your code, but these comparisons should all be
Kevin Millikin (Chromium)
2011/05/30 16:32:29
Scratch that. The byte is zero extended and it's
|
| // Throw away the result of the constructor invocation and use the |
| @@ -1264,9 +1264,9 @@ void Builtins::Generate_FunctionCall(MacroAssembler* masm) { |
| __ cmp(r2, r3); |
| __ b(eq, &use_global_receiver); |
| - __ CompareObjectType(r2, r3, r3, FIRST_JS_OBJECT_TYPE); |
| + __ CompareObjectType(r2, r3, r3, FIRST_SPEC_OBJECT_TYPE); |
| __ b(lt, &convert_to_object); |
| - __ cmp(r3, Operand(LAST_JS_OBJECT_TYPE)); |
| + __ cmp(r3, Operand(LAST_SPEC_OBJECT_TYPE)); |
| __ b(le, &shift_arguments); |
| __ bind(&convert_to_object); |
| @@ -1443,9 +1443,9 @@ void Builtins::Generate_FunctionApply(MacroAssembler* masm) { |
| // Check if the receiver is already a JavaScript object. |
| // r0: receiver |
| - __ CompareObjectType(r0, r1, r1, FIRST_JS_OBJECT_TYPE); |
| + __ CompareObjectType(r0, r1, r1, FIRST_SPEC_OBJECT_TYPE); |
| __ b(lt, &call_to_object); |
| - __ cmp(r1, Operand(LAST_JS_OBJECT_TYPE)); |
| + __ cmp(r1, Operand(LAST_SPEC_OBJECT_TYPE)); |
| __ b(le, &push_receiver); |
| // Convert the receiver to a regular object. |