src/ia32/macro-assembler-ia32.cc - Issue 6992072: Implement set trap for proxies, and revamp class hierarchy in preparation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 6992072: Implement set trap for proxies, and revamp class hierarchy in preparation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 8aa28a01639d87f395199472825686668abcce0e..0daaa506c197a85a4bc9e3318218b0eac27deddd 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -331,8 +331,9 @@ void MacroAssembler::IsInstanceJSObjectType(Register map,

Label* fail) {

movzx_b(scratch, FieldOperand(map, Map::kInstanceTypeOffset));

- sub(Operand(scratch), Immediate(FIRST_JS_OBJECT_TYPE));

- cmp(scratch, LAST_JS_OBJECT_TYPE - FIRST_JS_OBJECT_TYPE);

+ sub(Operand(scratch), Immediate(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE));

+ cmp(scratch,

+ LAST_NONCALLABLE_SPEC_OBJECT_TYPE - FIRST_NONCALLABLE_SPEC_OBJECT_TYPE);

j(above, fail);

}

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »