Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 6992069: Get remoting units working correctly. (Closed)

Created:
9 years, 7 months ago by dmac
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Get remoting units working correctly. And make them easier to read. BUG=NONE TEST=Run remoting. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M remoting/webapp/me2mom/remoting_session.js View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dmac
PTAL.
9 years, 7 months ago (2011-05-25 17:06:19 UTC) #1
garykac
On 2011/05/25 17:06:19, dmac wrote: > PTAL. LGTM
9 years, 7 months ago (2011-05-25 17:09:16 UTC) #2
Sergey Ulanov
being a pedant: should we use KiBps and MiBps instead (see http://en.wikipedia.org/wiki/Data_rate_units)?
9 years, 7 months ago (2011-05-25 18:29:06 UTC) #3
Wez
Is there a reason why we want to report bandwidth in Ki[lo/bi]Bytes per second rather ...
9 years, 7 months ago (2011-05-25 18:40:00 UTC) #4
dmaclach1
Because people who care will be aware of the difference between KB and Kb, and ...
9 years, 7 months ago (2011-05-25 18:44:12 UTC) #5
awong
9 years, 7 months ago (2011-05-25 18:53:29 UTC) #6
Danger! Danger!  Bikeshed alert!

If you want to change it, push up a CL.

-Albert


On Wed, May 25, 2011 at 11:40 AM, <wez@chromium.org> wrote:

> Is there a reason why we want to report bandwidth in Ki[lo/bi]Bytes per
> second
> rather than Ki[lo/bi]bits?  Network throughputs are normally expressed
> using the
> latter, so it seems more useful for us to do the same here.
>
>
> http://codereview.chromium.org/6992069/
>

Powered by Google App Engine
This is Rietveld 408576698