Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 6992051: MIPS: port Fix calls of strict mode function with an implicit receiver. (Closed)

Created:
9 years, 7 months ago by Paul Lind
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Fix calls of strict mode function with an implicit receiver. Port of r8040 to mips. Original commit message: Strict mode functions are to get 'undefined' as the receiver when called with an implicit receiver. Modes are bad! It forces us to have checks on all function calls. This change attempts to limit the cost by passing information about whether or not a call is with an implicit or explicit receiver in ecx as part of the calling convention. The cost is setting ecx on all calls and checking ecx on entry to strict mode functions. Implicit/explicit receiver state has to be maintained by ICs. Various stubs have to not clobber ecx or save and restore it. CallFunction stub needs to check if the receiver is implicit when it doesn't know from the context. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -72 lines) Patch
M src/mips/builtins-mips.cc View 7 chunks +14 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +27 lines, -27 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 8 chunks +27 lines, -11 lines 0 comments Download
M src/mips/ic-mips.cc View 8 chunks +30 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +13 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 7 chunks +33 lines, -7 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 5 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 7 months ago (2011-05-25 02:12:36 UTC) #1
Mads Ager (chromium)
9 years, 7 months ago (2011-05-25 05:57:33 UTC) #2
LGTM, I'll land.

Powered by Google App Engine
This is Rietveld 408576698