chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js - Issue 6992047: Change the web store private install API to accept a localized extension name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

Issue 6992047: Change the web store private install API to accept a localized extension name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased, removed test files I added in separate CL Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webstore_private/common.js ('k') | chrome/test/data/extensions/api_test/webstore_private/no_user_gesture.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

diff --git a/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js b/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

index 839584b5ddaa2d61b5d8232b76d38395a6210678..752d3efba21e46142cdffff5e5112843e74e99af 100644

--- a/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

+++ b/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

@@ -11,10 +11,8 @@ var manifest = alterManifest(manifestObj);

// that we get an install error after unpacking the crx file because the crx

// file's manifest won't match what we provided for the confirmation dialog

// here.

-chrome.webstorePrivate.beginInstallWithManifest(

- extensionId,

- "",

- manifest,

+chrome.webstorePrivate.beginInstallWithManifest2(

+ { 'id': extensionId, 'manifest': manifest },

function(result) {

assertNoLastError();

assertEq("", result);