Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

Issue 6992047: Change the web store private install API to accept a localized extension name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased, removed test files I added in separate CL Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
index bc31c453995904570ca9b5257364aedbbd9fefd9..165f571c9049bfb9dab23cd93ca2681d9a269890 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
@@ -27,6 +27,7 @@ namespace {
void OnUnpackSuccess(const FilePath& temp_dir,
const FilePath& extension_root,
+ const DictionaryValue* original_manifest,
const Extension* extension) {
// Don't delete temp_dir here, we need to do some post op checking.
}
@@ -38,16 +39,17 @@ class MockSandboxedExtensionUnpackerClient
public:
virtual ~MockSandboxedExtensionUnpackerClient() {}
- MOCK_METHOD3(OnUnpackSuccess,
+ MOCK_METHOD4(OnUnpackSuccess,
void(const FilePath& temp_dir,
const FilePath& extension_root,
+ const DictionaryValue* original_manifest,
const Extension* extension));
MOCK_METHOD1(OnUnpackFailure,
void(const std::string& error));
void DelegateToFake() {
- ON_CALL(*this, OnUnpackSuccess(_, _, _))
+ ON_CALL(*this, OnUnpackSuccess(_, _, _, _))
.WillByDefault(Invoke(::OnUnpackSuccess));
}
};
@@ -157,7 +159,7 @@ class SandboxedExtensionUnpackerTest : public testing::Test {
};
TEST_F(SandboxedExtensionUnpackerTest, NoCatalogsSuccess) {
- EXPECT_CALL(*client_, OnUnpackSuccess(_, _, _));
+ EXPECT_CALL(*client_, OnUnpackSuccess(_, _, _, _));
EXPECT_CALL(*client_, OnUnpackFailure(_)).Times(0);
SetupUnpacker("no_l10n.crx");
@@ -179,7 +181,7 @@ TEST_F(SandboxedExtensionUnpackerTest, NoCatalogsSuccess) {
}
TEST_F(SandboxedExtensionUnpackerTest, WithCatalogsSuccess) {
- EXPECT_CALL(*client_, OnUnpackSuccess(_, _, _));
+ EXPECT_CALL(*client_, OnUnpackSuccess(_, _, _, _));
EXPECT_CALL(*client_, OnUnpackFailure(_)).Times(0);
SetupUnpacker("good_l10n.crx");
« no previous file with comments | « chrome/browser/extensions/sandboxed_extension_unpacker.cc ('k') | chrome/common/extensions/api/extension_api.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698