Change the web store private install API to accept a localized extension name.

chrome/browser/extensions/extension_webstore_private_api.h

Index: chrome/browser/extensions/extension_webstore_private_api.h
diff --git a/chrome/browser/extensions/extension_webstore_private_api.h b/chrome/browser/extensions/extension_webstore_private_api.h
index 4acc7f6f8b56bfe212a2bd5a26ef6addd1e7d1a5..3c909e14ac33ed36c8f236975aa21e1f2d4710b2 100644
--- a/chrome/browser/extensions/extension_webstore_private_api.h
+++ b/chrome/browser/extensions/extension_webstore_private_api.h
@@ -106,6 +106,7 @@ class BeginInstallWithManifestFunction : public AsyncExtensionFunction,
   std::string id_;
   std::string manifest_;
   std::string icon_data_;
+  std::string localized_name_;
 
   // The results of parsing manifest_ and icon_data_ go into these two.
   scoped_ptr<DictionaryValue> parsed_manifest_;
@@ -114,7 +115,7 @@ class BeginInstallWithManifestFunction : public AsyncExtensionFunction,
   // A dummy Extension object we create for the purposes of using
   // ExtensionInstallUI to prompt for confirmation of the install.
   scoped_refptr<Extension> dummy_extension_;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest");
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest2");

[Matt Perry, 2011/05/25 01:46:06]

Why the rename?

[asargent_no_longer_on_chrome, 2011/05/25 04:42:00]

The webstore is still just using the old beginInstall() method that just takes
an id, and no production code is using the newer but i18n-broken
beginInstallWithManifest method. Since I changed the method signature in a
breaking way, to take a details object instead of a list of parameters, I wanted
a way they could reliably detect if the newest version of the function was
available without having to know that my change hit chrome in a specific version
and check the user-agent. 

[Matt Perry, 2011/05/25 19:03:24]

Makes sense. Thanks.

 };
 
 class CompleteInstallFunction : public SyncExtensionFunction {