Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 6992026: Bug fixes in matrix driven test and some minor changes in perf media test. (Closed)

Created:
9 years, 7 months ago by imasaki1
Modified:
9 years, 6 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, John Grabowski, Paweł Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, dyu1, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), anantha, scherkus (not reviewing), alrhodes
Visibility:
Public.

Description

Bug fixes in matrix driven test and some minor changes. Also, adding media_matrix_data_public.csv for videos that are in trunk/deps/avperf/{bear,tulip}. Bug fixes includes: * CSV file abnormality * the order of returned tuples in _GenerateMediaInfo and LookForMediaInfoInCompactFormByNickName was incorrect * not recognize the second column of CSV as tag * par_filename was not set in the case of matrix driven test. Added features: * -c and -z option to control the number of tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -23 lines) Patch
M chrome/test/data/media/csv/media_matrix_data.csv View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/test/data/media/csv/media_matrix_data_public.csv View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/test/functional/media/media_test_matrix.py View 3 chunks +12 lines, -10 lines 0 comments Download
M chrome/test/functional/media/media_test_matrix_unittest.py View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/functional/media/media_test_runner.py View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
imasaki1
Thank you very much.
9 years, 7 months ago (2011-05-24 17:11:25 UTC) #1
dennis_jeffrey
LGTM
9 years, 7 months ago (2011-05-24 17:23:39 UTC) #2
Nirnimesh
LGTM Please be descriptive and specific and the CL title and description. The rule of ...
9 years, 7 months ago (2011-05-24 17:32:25 UTC) #3
imasaki1
On 2011/05/24 17:32:25, Nirnimesh wrote: > LGTM > > Please be descriptive and specific and ...
9 years, 7 months ago (2011-05-24 19:10:59 UTC) #4
Nirnimesh
Looks much better now. Thanks! LGTM
9 years, 7 months ago (2011-05-24 19:17:43 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-25 15:58:25 UTC) #6
Change committed as 86627

Powered by Google App Engine
This is Rietveld 408576698