Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6010)

Unified Diff: chrome/browser/extensions/extension_proxy_apitest.cc

Issue 6992022: Move Proxy Settings API out of experimental (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Bernhard's comment Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_proxy_apitest.cc
diff --git a/chrome/browser/extensions/extension_proxy_apitest.cc b/chrome/browser/extensions/extension_proxy_apitest.cc
index 6f1b9bb362a7a52f341321bf3dd7dfbee08b91f8..060e3fcf133d564092abbdc492df6efe8e52866b 100644
--- a/chrome/browser/extensions/extension_proxy_apitest.cc
+++ b/chrome/browser/extensions/extension_proxy_apitest.cc
@@ -70,9 +70,6 @@ class ProxySettingsApiTest : public ExtensionApiTest {
// Tests direct connection settings.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyDirectSettings) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/direct")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -84,9 +81,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyDirectSettings) {
// Tests auto-detect settings.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyAutoSettings) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/auto")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -98,9 +92,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyAutoSettings) {
// Tests PAC proxy settings.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacScript) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/pac")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -112,9 +103,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacScript) {
// Tests PAC proxy settings.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacData) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/pacdata")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -129,9 +117,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyPacData) {
// Tests setting a single proxy to cover all schemes.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedSingle) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/single")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -146,9 +131,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedSingle) {
// Tests setting to use the system's proxy settings.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxySystem) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/system")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -160,9 +142,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxySystem) {
// Tests setting separate proxies for each scheme.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividual) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/individual")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -193,9 +172,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividual) {
// TODO(battre): re-enable when incognito is supported again
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
DISABLED_ProxyFixedIndividualIncognitoOnly) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/individual_incognito_only")) <<
message_;
const Extension* extension = GetSingleLoadedExtension();
@@ -220,9 +196,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
// TODO(battre): re-enable when incognito is supported again
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
DISABLED_ProxyFixedIndividualIncognitoAlso) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/individual_incognito_also")) <<
message_;
const Extension* extension = GetSingleLoadedExtension();
@@ -252,9 +225,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
// Tests setting and unsetting values
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividualRemove) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/individual_remove")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -265,9 +235,6 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividualRemove) {
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
ProxyBypass) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTestIncognito("proxy/bypass")) << message_;
const Extension* extension = GetSingleLoadedExtension();
ASSERT_TRUE(extension);
@@ -290,8 +257,5 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
// Tests error events.
IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyEvents) {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableExperimentalExtensionApis);
-
ASSERT_TRUE(RunExtensionTest("proxy/events")) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698