Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 6992017: GTK: Allow resizing the findbar when the window is narrow. (Closed)

Created:
9 years, 7 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
jennb, Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Allow resizing the findbar when the window is narrow. BUG=none TEST=manual (made sure it pixel-matched the old find bar, in both normal and GTK+ theme modes) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86637

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 7 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
It would be kind to say that the findbar widget hierarchy, positioning and sizing code ...
9 years, 7 months ago (2011-05-24 02:49:04 UTC) #1
jennb
LGTM I patched in your change and tested it manually and against my test. Does ...
9 years, 7 months ago (2011-05-24 16:37:23 UTC) #2
Elliot Glaysher
9 years, 7 months ago (2011-05-24 17:12:57 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698