Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 6992010: Added proxy / stub pair for GPU surfaces. (Closed)

Created:
9 years, 7 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam, Jói
Visibility:
Public.

Description

Added proxy / stub pair for GPU surfaces. This doesn't do anything useful yet beyond allowing the renderer process to manage the lifetime of an offscreen GLSurface in the GPU process. More to come. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86482

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -983 lines) Patch
M content/common/gpu/gpu_channel.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +9 lines, -0 lines 0 comments Download
A + content/common/gpu/gpu_surface_stub.h View 1 chunk +17 lines, -113 lines 0 comments Download
A + content/common/gpu/gpu_surface_stub.cc View 1 chunk +13 lines, -414 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu_channel_host.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/gpu_channel_host.cc View 2 chunks +24 lines, -0 lines 0 comments Download
A + content/renderer/gpu_surface_proxy.h View 1 2 chunks +9 lines, -84 lines 0 comments Download
A + content/renderer/gpu_surface_proxy.cc View 1 chunk +9 lines, -368 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
jam, i need OWNERS review for the gypi files and the stuff in content/renderer/gpu_*. I ...
9 years, 7 months ago (2011-05-23 23:43:43 UTC) #1
Ken Russell (switch to Gerrit)
Basically LGTM. I don't know what the design constraints are; upon first impression it seemed ...
9 years, 7 months ago (2011-05-24 00:44:32 UTC) #2
apatrick_chromium
On 2011/05/24 00:44:32, kbr wrote: > Basically LGTM. I don't know what the design constraints ...
9 years, 7 months ago (2011-05-24 01:08:10 UTC) #3
jam
9 years, 7 months ago (2011-05-24 20:37:32 UTC) #4
content lgtm

it might be good to move all the gpu related code in content\renderer to a gpu
subdirectory so that you don't get hassled waiting for owners lgtm

Powered by Google App Engine
This is Rietveld 408576698