Issue 6992008: Ensure that context menu->Print works in ChromeFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6992008: Ensure that context menu->Print works in ChromeFrame. (Closed)

Created:
9 years, 7 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ensure that context menu->Print works in ChromeFrame. Fixes bug http://code.google.com/p/chromium/issues/detail?id=83661 BUG=83661 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86369

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome_frame/chrome_frame_activex_base.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

9 years, 7 months ago (2011-05-23 23:17:43 UTC) #2

lgtm

On Mon, May 23, 2011 at 4:03 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Ensure that context menu->Print works in ChromeFrame.
>
> Fixes bug http://code.google.com/p/chromium/issues/detail?id=83661
>
> BUG=83661
>
> Please review this at http://codereview.chromium.org/6992008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_frame_activex_base.h
>
>
> Index: chrome_frame/chrome_frame_activex_base.h
> ===================================================================
> --- chrome_frame/chrome_frame_activex_base.h    (revision 86295)
> +++ chrome_frame/chrome_frame_activex_base.h    (working copy)
> @@ -24,6 +24,7 @@
>  #include "base/win/scoped_comptr.h"
>  #include "base/win/scoped_variant.h"
>  #include "grit/chrome_frame_resources.h"
> +#include "chrome/app/chrome_command_ids.h"
>  #include "chrome/common/url_constants.h"
>  #include "chrome_frame/chrome_frame_plugin.h"
>  #include "chrome_frame/com_message_event.h"
> @@ -352,6 +353,11 @@
>           DoFileDownloadInIE(UTF8ToWide(url.spec()).c_str());
>           return true;
>         }
> +
> +        case IDC_PRINT: {
> +          automation_client_->PrintTab();
> +          break;
> +        }
>       }
>     }
>
>
>
>

Expand Messages | Collapse Messages