Issue 6990074: Change GetVisitCountToHost() to GetVisibleVisitCountToHost(), and restrict it to returning "user-...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990074: Change GetVisitCountToHost() to GetVisibleVisitCountToHost(), and restrict it to returning "user-... (Closed)

Created:
9 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
jschuh

CC:
chromium-reviews, Paweł Hajdan Jr., rdsmith+dwatch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change GetVisitCountToHost() to GetVisibleVisitCountToHost(), and restrict it to returning "user-visible" visits. This makes the Page Info bubble and the download system more restrictive about considering when someone "first visited" a site, so that they don't consider things like subframe navigations or redirects. BUG=81741 TEST=Page Info bubble should not say you've visited a site before today if your only visits in previous days were subframe navigations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86695

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -42 lines)			Patch
M	chrome/browser/download/download_history.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history.h	View		1 chunk	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/history/history.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_marshaling.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/history/visit_database.h	View		1 chunk	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/history/visit_database.cc	View		2 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/page_info_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm (brought to you by the letter "s").

Expand Messages | Collapse Messages