Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4838)

Unified Diff: chrome/browser/resources/active_downloads.html

Issue 6990067: Suppress browser shortcuts. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/active_downloads.html
===================================================================
--- chrome/browser/resources/active_downloads.html (revision 86295)
+++ chrome/browser/resources/active_downloads.html (working copy)
@@ -220,6 +220,11 @@
localStrings = new LocalStrings();
initTestHarness();
+ // Suppress browser shortcuts.
+ window.onkeydown = function(e) {
rginda 2011/05/25 04:13:38 LGTM as long as you're sure you want to suppress *
achuithb 2011/05/25 06:58:25 I don't think we want any shortcuts for the pop-up
xiyuan 2011/05/25 16:55:51 Ctrl+W is useful, I think. Yeah, I saw the TEST s
+ e.preventDefault();
+ };
+
$('showalldownloadstext').textContent =
localStrings.getString('showalldownloads');
@@ -264,7 +269,7 @@
/**
* Create a results array with test data and call downloadsList.
*/
-var id = 1;
+var id = 0;
rginda 2011/05/25 04:13:38 Is this here on purpose?
achuithb 2011/05/25 06:58:25 Ya, test code. 0 is a better place to start.
var results = [];
function sendTestResults() {
results.push({
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698