Suppress browser shortcuts.

Suppress browser shortcuts.

BUG=chromium-os:14964
TEST=Ctrl-o, Ctrl-r, Ctrl-b and ctrl-s should no longer work. ctrl-n, ctrl-w will continue to work.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86656

[achuithb, 2011-05-24 22:41:03]

Please bless.

[rginda, 2011-05-25 04:13:37]

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
File chrome/browser/resources/active_downloads.html (right):

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
chrome/browser/resources/active_downloads.html:224: window.onkeydown =
function(e) {
LGTM as long as you're sure you want to suppress *all* shortcuts rather than
blacklisting known trouble combos.

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
chrome/browser/resources/active_downloads.html:272: var id = 0;
Is this here on purpose?

[achuithb, 2011-05-25 06:58:25]

Thanks for the review!

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
File chrome/browser/resources/active_downloads.html (right):

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
chrome/browser/resources/active_downloads.html:224: window.onkeydown =
function(e) {
I don't think we want any shortcuts for the pop-up. Can you think of any that
would be useful?

On 2011/05/25 04:13:38, rginda wrote:
> LGTM as long as you're sure you want to suppress *all* shortcuts rather than
> blacklisting known trouble combos.

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
chrome/browser/resources/active_downloads.html:272: var id = 0;
On 2011/05/25 04:13:38, rginda wrote:
> Is this here on purpose?

Ya, test code. 0 is a better place to start.

[xiyuan, 2011-05-25 16:55:51]

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
File chrome/browser/resources/active_downloads.html (right):

http://codereview.chromium.org/6990067/diff/1/chrome/browser/resources/active...
chrome/browser/resources/active_downloads.html:224: window.onkeydown =
function(e) {
Ctrl+W is useful, I think.

Yeah, I saw the TEST says it works. But I wonder if it still works after you
click inside the download panel. The click should put focus on the
RenderWidgetHostView (or something like that) and makes the window here get key
events first.

On 2011/05/25 06:58:25, achuith.bhandarkar wrote:
> I don't think we want any shortcuts for the pop-up. Can you think of any that
> would be useful?
> 
> On 2011/05/25 04:13:38, rginda wrote:
> > LGTM as long as you're sure you want to suppress *all* shortcuts rather than
> > blacklisting known trouble combos.
>

[xiyuan, 2011-05-25 17:36:17]

LGTM

Achuith confirmed that Ctrl+W works after clicking on panel contents.

[achuithb, 2011-05-25 17:40:38]

Thanks for the reviews rginda & xiyuan!