Mac TimeMachine File Exclusions

chrome/browser/history/history_database.cc

Index: chrome/browser/history/history_database.cc
===================================================================
--- chrome/browser/history/history_database.cc	(revision 86429)
+++ chrome/browser/history/history_database.cc	(working copy)
@@ -97,12 +97,8 @@
     return sql::INIT_FAILURE;
 
 #if defined(OS_MACOSX)
-  // Exclude the history file and its journal from backups.
+  // Exclude the history file from backups.

[Mark Mentovai, 2011/05/25 01:14:35]

Are we guaranteed that the -journal file does not yet exist at this point?

[mrossetti, 2011/05/26 21:02:40]

No, it might exist as a result of the app crashing. If it does exist then it
will be deleted and recreated at the next transaction. Are you concerned that we
might get a stale -journal that has not been excluded?

[Mark Mentovai, 2011/05/26 21:23:40]

mrossetti wrote:
I wasn’t worried about stale journals from previous crashed runs.

I was worried that the -journal might already have been created by this point by
sqlite. In that case, the sqlite code would have missed the opportunity to
exclude the -journal, because the main database isn’t excluded until right here.

   base::mac::SetFileBackupExclusion(history_name, true);
-  FilePath::StringType history_name_string(history_name.value());
-  history_name_string += "-journal";
-  FilePath history_journal_name(history_name_string);
-  base::mac::SetFileBackupExclusion(history_journal_name, true);
 #endif
 
   // Prime the cache.