ntp4: fix brokeness when new apps are added

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 61 matching lines @@
   /**
    * The time in milliseconds for most transitions.  This should match what's
    * in new_tab.css.  Unfortunately there's no better way to try to time
    * something to occur until after a transition has completed.
    * @type {number}
    * @const
    */
   var DEFAULT_TRANSITION_TIME = 500;
 
   /**
-   * All the Grabber objects currently in use on the page
-   * @type {Array.<Grabber>}
-   */
-  var grabbers = [];
-
-  /**
    * Invoked at startup once the DOM is available to initialize the app.
    */
   function initialize() {
     // Load the current theme colors.
     themeChanged();
 
     dotList = getRequiredElement('dot-list');
     pageList = getRequiredElement('page-list');
     trash = getRequiredElement('trash');
     trash.hidden = true;
@@ skipping 112 matching lines @@
   /**
    * Callback invoked by chrome with the apps available.
    *
    * Note that calls to this function can occur at any time, not just in
    * response to a getApps request. For example, when a user installs/uninstalls
    * an app on another synchronized devices.
    * @param {Object} data An object with all the data on available
    *        applications.
    */
   function getAppsCallback(data) {
-    // Clean up any existing grabber objects - cancelling any outstanding drag.
-    // Ideally an async app update wouldn't disrupt an active drag but
-    // that would require us to re-use existing elements and detect how the apps
-    // have changed, which would be a lot of work.
-    // Note that we have to explicitly clean up the grabber objects so they stop
-    // listening to events and break the DOM<->JS cycles necessary to enable
-    // collection of all these objects.
-    grabbers.forEach(function(g) {
-      // Note that this may raise DRAG_END/RELEASE events to clean up an
-      // oustanding drag.
-      g.dispose();
-    });
-    assert(!draggingAppContainer && !draggingAppOriginalPosition &&
-           !draggingAppOriginalPage);
-    grabbers = [];
-
     // Clear any existing apps pages and dots.
     // TODO(rbyers): It might be nice to preserve animation of dots after an
     // uninstall. Could we re-use the existing page and dot elements?  It seems
     // unfortunate to have Chrome send us the entire apps list after an
     // uninstall.
-    for (var i = 0; i < appsPages.length; i++) {
-      var page = appsPages[i];
+    while (appsPages.length > 0) {
+      var page = appsPages[0];
       var dot = page.navigationDot;
 
       page.tearDown();
       page.parentNode.removeChild(page);
       dot.parentNode.removeChild(dot);
     }
 
     // Get the array of apps and add any special synthesized entries
     var apps = data.apps;
 
@@ skipping 84 matching lines @@
    * Appends a tile page (for apps or most visited).
    *
    * @param {TilePage} page The page element.
    * @param {boolean=} opt_animate If true, add the class 'new' to the created
    *        dot.
    */
   function appendTilePage(page, opt_animate) {
     pageList.appendChild(page);
 
     // Make a deep copy of the dot template to add a new one.
-    var dotCount = dots.length;
     var newDot = dotTemplate.cloneNode(true);
     newDot.querySelector('span').textContent = page.pageName;
     if (opt_animate)
       newDot.classList.add('new');
     dotList.appendChild(newDot);
     page.navigationDot = newDot;
 
     newDot.showPage = function() {
-      cardSlider.selectCard(dotCount, true);
+      cardSlider.selectCardByValue(page, true);
     };
     function switchPage(e) {
       newDot.showPage();
       e.stopPropagation();
     }
     // Add click handler to the dot to change the page.
     // TODO(rbyers): Perhaps this should be TouchHandler.START_EVENT_ (so we
     // don't rely on synthesized click events, and the change takes effect
     // before releasing). However, click events seems to be synthesized for a
     // region outside the border, and a 10px box is too small to require touch
@@ skipping 367 matching lines @@
 // TODO(estade): update the content handlers to use ntp namespace instead of
 // making these global.
 var assert = ntp4.assert;
 var getAppsCallback = ntp4.getAppsCallback;
 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
 var themeChanged = ntp4.themeChanged;
 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
 var setMostVisitedPages = ntp4.setMostVisitedPages;
 
 document.addEventListener('DOMContentLoaded', ntp4.initialize);