Issue 6990063: ntp4: fix brokeness when new apps are added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990063: ntp4: fix brokeness when new apps are added (Closed)

Created:
9 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
csilv

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: fix brokeness when new apps are added this code should go away soon but for now this is less broke. BUG=none TEST=when you add a new app, the nav dots at the bottom don't break horribly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86479

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -26 lines)			Patch
	M	chrome/browser/resources/ntp4/card_slider.js	View		1 chunk	+10 lines, -0 lines	1 comment	Download
	M	chrome/browser/resources/ntp4/new_tab.js	View		4 chunks	+3 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

9 years, 7 months ago (2011-05-24 19:50:18 UTC) #2

LGTM

http://codereview.chromium.org/6990063/diff/1/chrome/browser/resources/ntp4/c...
File chrome/browser/resources/ntp4/card_slider.js (right):

http://codereview.chromium.org/6990063/diff/1/chrome/browser/resources/ntp4/c...
chrome/browser/resources/ntp4/card_slider.js:275: selectCardByValue:
function(newCard, opt_animate) {
nit: Add a function comment.

Expand Messages | Collapse Messages