Switch to the new CustomHistogram::ArrayToCustomRanges() utility

base/metrics/histogram.cc

Index: base/metrics/histogram.cc
diff --git a/base/metrics/histogram.cc b/base/metrics/histogram.cc
index 6fd30be87ab8d8da79163fb7ab10d53e42f0d553..557ca4498b51ca3ccbdfbd846d05a3fcd7c2500d 100644
--- a/base/metrics/histogram.cc
+++ b/base/metrics/histogram.cc
@@ -946,6 +946,7 @@ std::vector<Histogram::Sample> CustomHistogram::ArrayToCustomRanges(
   std::vector<Sample> all_values;
   for (size_t i = 0; i < num_values; ++i) {
     Sample value = values[i];
+    DCHECK_GE(value, 0);  // You must use positive sample values.

[jar (doing other things), 2011/05/24 18:10:07]

This is a good idea (I love DCHECKS).  It would be better to push this down into
the constructor, and assert that we never get fed a negative number.  That would
catch more problems (since it is at a lower level).  I'd even be ok with making
this a CHECK() (release time assertion), as I'm not sure how well the code would
handle negative values during searches. I'm pretty sure the first (least) value
in the range MUST be 0, which would break if some negative values were sorted
into the mix

[Jói, 2011/05/24 18:27:31]

I moved it to Histogram::SetBucketRange. Let me know if that is wrong.

I left it as a DCHECK to match the other checks that are in place in the class.

     all_values.push_back(value);
 
     // Ensure that a guard bucket is added. If we end up with duplicate