Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 6990057: It suffices to just forward-declare DnsCertProvenanceChecker (Closed)

Created:
9 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

It suffices to just forward-declare DnsCertProvenanceChecker in net/url_request/url_request_context.h. Remove an unnecessary forward declaration of SSLConfigService. R=agl@chromium.org BUG=none TEST=no compilation errors Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86452

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +0 lines, -2 lines 2 comments Download
M net/url_request/url_request_context_storage.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
Please review url_request_context.h first. The changes to other files are a result of that change. ...
9 years, 7 months ago (2011-05-24 14:53:37 UTC) #1
agl
LGTM
9 years, 7 months ago (2011-05-24 14:56:26 UTC) #2
commit-bot: I haz the power
Presubmit check for 6990057-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-24 16:56:36 UTC) #3
willchan no longer on Chromium
LGTM stamp. On Tue, May 24, 2011 at 4:56 PM, <commit-bot@chromium.org> wrote: > Presubmit check ...
9 years, 7 months ago (2011-05-24 16:57:45 UTC) #4
commit-bot: I haz the power
9 years, 7 months ago (2011-05-24 18:03:11 UTC) #5
Change committed as 86452

Powered by Google App Engine
This is Rietveld 408576698