Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6990049: GTK: Refinements to the global menu. (Closed)

Created:
9 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Refinements to the global menu. 1) When a bookmark has no title, use the truncated URL. 2) Force the rest of the icons to display in gnome. (We only forced it on recently closed tabs, not bookmarks or most visited). BUG=83646 TEST=Invariants 1 and 2 above are true on Natty. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/global_bookmark_menu.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
9 years, 7 months ago (2011-05-23 22:16:54 UTC) #1
Evan Stade
9 years, 7 months ago (2011-05-24 01:11:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698