Issue 6990048: Add NativeWidgetViews. This is a stub implementation that mostly just defers to its parent Native...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990048: Add NativeWidgetViews. This is a stub implementation that mostly just defers to its parent Native... (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add NativeWidgetViews. This is a stub implementation that mostly just defers to its parent NativeWidget. http://crbug.com/83663 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86488

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+399 lines, -0 lines)			Patch
M	views/examples/examples_main.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
A	views/examples/native_widget_views_example.h	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download
A	views/examples/native_widget_views_example.cc	View	2	1 chunk	+35 lines, -0 lines	0 comments	Download
M	views/views.gyp	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	views/widget/native_widget.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	views/widget/native_widget_views.h	View	2	1 chunk	+86 lines, -0 lines	0 comments	Download
A	views/widget/native_widget_views.cc	View	2	1 chunk	+236 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 7 months ago (2011-05-23 22:36:15 UTC) #2

LGTM

http://codereview.chromium.org/6990048/diff/1/views/examples/native_widget_vi...
File views/examples/native_widget_views_example.h (right):

http://codereview.chromium.org/6990048/diff/1/views/examples/native_widget_vi...
views/examples/native_widget_views_example.h:16: class TextButton;
nuke this as you're not using it.

http://codereview.chromium.org/6990048/diff/1/views/examples/native_widget_vi...
views/examples/native_widget_views_example.h:31: 
nuke newline.

Expand Messages | Collapse Messages