Index: third_party/sqlite/src/src/vdbeblob.c |
diff --git a/third_party/sqlite/src/src/vdbeblob.c b/third_party/sqlite/src/src/vdbeblob.c |
index 009234f4ef7f7f5995d4ed454af221e94672e0a3..18fdd465ae013996cfcfcdef18d04f39c9864228 100644 |
--- a/third_party/sqlite/src/src/vdbeblob.c |
+++ b/third_party/sqlite/src/src/vdbeblob.c |
@@ -11,8 +11,6 @@ |
************************************************************************* |
** |
** This file contains code used to implement incremental BLOB I/O. |
-** |
-** $Id: vdbeblob.c,v 1.35 2009/07/02 07:47:33 danielk1977 Exp $ |
*/ |
#include "sqliteInt.h" |
@@ -28,11 +26,82 @@ struct Incrblob { |
int flags; /* Copy of "flags" passed to sqlite3_blob_open() */ |
int nByte; /* Size of open blob, in bytes */ |
int iOffset; /* Byte offset of blob in cursor data */ |
+ int iCol; /* Table column this handle is open on */ |
BtCursor *pCsr; /* Cursor pointing at blob row */ |
sqlite3_stmt *pStmt; /* Statement holding cursor open */ |
sqlite3 *db; /* The associated database */ |
}; |
+ |
+/* |
+** This function is used by both blob_open() and blob_reopen(). It seeks |
+** the b-tree cursor associated with blob handle p to point to row iRow. |
+** If successful, SQLITE_OK is returned and subsequent calls to |
+** sqlite3_blob_read() or sqlite3_blob_write() access the specified row. |
+** |
+** If an error occurs, or if the specified row does not exist or does not |
+** contain a value of type TEXT or BLOB in the column nominated when the |
+** blob handle was opened, then an error code is returned and *pzErr may |
+** be set to point to a buffer containing an error message. It is the |
+** responsibility of the caller to free the error message buffer using |
+** sqlite3DbFree(). |
+** |
+** If an error does occur, then the b-tree cursor is closed. All subsequent |
+** calls to sqlite3_blob_read(), blob_write() or blob_reopen() will |
+** immediately return SQLITE_ABORT. |
+*/ |
+static int blobSeekToRow(Incrblob *p, sqlite3_int64 iRow, char **pzErr){ |
+ int rc; /* Error code */ |
+ char *zErr = 0; /* Error message */ |
+ Vdbe *v = (Vdbe *)p->pStmt; |
+ |
+ /* Set the value of the SQL statements only variable to integer iRow. |
+ ** This is done directly instead of using sqlite3_bind_int64() to avoid |
+ ** triggering asserts related to mutexes. |
+ */ |
+ assert( v->aVar[0].flags&MEM_Int ); |
+ v->aVar[0].u.i = iRow; |
+ |
+ rc = sqlite3_step(p->pStmt); |
+ if( rc==SQLITE_ROW ){ |
+ u32 type = v->apCsr[0]->aType[p->iCol]; |
+ if( type<12 ){ |
+ zErr = sqlite3MPrintf(p->db, "cannot open value of type %s", |
+ type==0?"null": type==7?"real": "integer" |
+ ); |
+ rc = SQLITE_ERROR; |
+ sqlite3_finalize(p->pStmt); |
+ p->pStmt = 0; |
+ }else{ |
+ p->iOffset = v->apCsr[0]->aOffset[p->iCol]; |
+ p->nByte = sqlite3VdbeSerialTypeLen(type); |
+ p->pCsr = v->apCsr[0]->pCursor; |
+ sqlite3BtreeEnterCursor(p->pCsr); |
+ sqlite3BtreeCacheOverflow(p->pCsr); |
+ sqlite3BtreeLeaveCursor(p->pCsr); |
+ } |
+ } |
+ |
+ if( rc==SQLITE_ROW ){ |
+ rc = SQLITE_OK; |
+ }else if( p->pStmt ){ |
+ rc = sqlite3_finalize(p->pStmt); |
+ p->pStmt = 0; |
+ if( rc==SQLITE_OK ){ |
+ zErr = sqlite3MPrintf(p->db, "no such rowid: %lld", iRow); |
+ rc = SQLITE_ERROR; |
+ }else{ |
+ zErr = sqlite3MPrintf(p->db, "%s", sqlite3_errmsg(p->db)); |
+ } |
+ } |
+ |
+ assert( rc!=SQLITE_OK || zErr==0 ); |
+ assert( rc!=SQLITE_ROW && rc!=SQLITE_DONE ); |
+ |
+ *pzErr = zErr; |
+ return rc; |
+} |
+ |
/* |
** Open a blob handle. |
*/ |
@@ -73,36 +142,35 @@ int sqlite3_blob_open( |
{OP_OpenWrite, 0, 0, 0}, /* 4: Open cursor 0 for read/write */ |
{OP_Variable, 1, 1, 1}, /* 5: Push the rowid to the stack */ |
- {OP_NotExists, 0, 9, 1}, /* 6: Seek the cursor */ |
+ {OP_NotExists, 0, 10, 1}, /* 6: Seek the cursor */ |
{OP_Column, 0, 0, 1}, /* 7 */ |
{OP_ResultRow, 1, 0, 0}, /* 8 */ |
- {OP_Close, 0, 0, 0}, /* 9 */ |
- {OP_Halt, 0, 0, 0}, /* 10 */ |
+ {OP_Goto, 0, 5, 0}, /* 9 */ |
+ {OP_Close, 0, 0, 0}, /* 10 */ |
+ {OP_Halt, 0, 0, 0}, /* 11 */ |
}; |
- Vdbe *v = 0; |
int rc = SQLITE_OK; |
char *zErr = 0; |
Table *pTab; |
- Parse *pParse; |
+ Parse *pParse = 0; |
+ Incrblob *pBlob = 0; |
+ flags = !!flags; /* flags = (flags ? 1 : 0); */ |
*ppBlob = 0; |
+ |
sqlite3_mutex_enter(db->mutex); |
+ |
+ pBlob = (Incrblob *)sqlite3DbMallocZero(db, sizeof(Incrblob)); |
+ if( !pBlob ) goto blob_open_out; |
pParse = sqlite3StackAllocRaw(db, sizeof(*pParse)); |
- if( pParse==0 ){ |
- rc = SQLITE_NOMEM; |
- goto blob_open_out; |
- } |
+ if( !pParse ) goto blob_open_out; |
+ |
do { |
memset(pParse, 0, sizeof(Parse)); |
pParse->db = db; |
- |
- if( sqlite3SafetyOn(db) ){ |
- sqlite3DbFree(db, zErr); |
- sqlite3StackFree(db, pParse); |
- sqlite3_mutex_leave(db->mutex); |
- return SQLITE_MISUSE; |
- } |
+ sqlite3DbFree(db, zErr); |
+ zErr = 0; |
sqlite3BtreeEnterAll(db); |
pTab = sqlite3LocateTable(pParse, 0, zTable, zDb); |
@@ -123,13 +191,12 @@ int sqlite3_blob_open( |
pParse->zErrMsg = 0; |
} |
rc = SQLITE_ERROR; |
- (void)sqlite3SafetyOff(db); |
sqlite3BtreeLeaveAll(db); |
goto blob_open_out; |
} |
/* Now search pTab for the exact column. */ |
- for(iCol=0; iCol < pTab->nCol; iCol++) { |
+ for(iCol=0; iCol<pTab->nCol; iCol++) { |
if( sqlite3StrICmp(pTab->aCol[iCol].zName, zColumn)==0 ){ |
break; |
} |
@@ -138,38 +205,59 @@ int sqlite3_blob_open( |
sqlite3DbFree(db, zErr); |
zErr = sqlite3MPrintf(db, "no such column: \"%s\"", zColumn); |
rc = SQLITE_ERROR; |
- (void)sqlite3SafetyOff(db); |
sqlite3BtreeLeaveAll(db); |
goto blob_open_out; |
} |
/* If the value is being opened for writing, check that the |
- ** column is not indexed. It is against the rules to open an |
- ** indexed column for writing. |
- */ |
+ ** column is not indexed, and that it is not part of a foreign key. |
+ ** It is against the rules to open a column to which either of these |
+ ** descriptions applies for writing. */ |
if( flags ){ |
+ const char *zFault = 0; |
Index *pIdx; |
+#ifndef SQLITE_OMIT_FOREIGN_KEY |
+ if( db->flags&SQLITE_ForeignKeys ){ |
+ /* Check that the column is not part of an FK child key definition. It |
+ ** is not necessary to check if it is part of a parent key, as parent |
+ ** key columns must be indexed. The check below will pick up this |
+ ** case. */ |
+ FKey *pFKey; |
+ for(pFKey=pTab->pFKey; pFKey; pFKey=pFKey->pNextFrom){ |
+ int j; |
+ for(j=0; j<pFKey->nCol; j++){ |
+ if( pFKey->aCol[j].iFrom==iCol ){ |
+ zFault = "foreign key"; |
+ } |
+ } |
+ } |
+ } |
+#endif |
for(pIdx=pTab->pIndex; pIdx; pIdx=pIdx->pNext){ |
int j; |
for(j=0; j<pIdx->nColumn; j++){ |
if( pIdx->aiColumn[j]==iCol ){ |
- sqlite3DbFree(db, zErr); |
- zErr = sqlite3MPrintf(db, |
- "cannot open indexed column for writing"); |
- rc = SQLITE_ERROR; |
- (void)sqlite3SafetyOff(db); |
- sqlite3BtreeLeaveAll(db); |
- goto blob_open_out; |
+ zFault = "indexed"; |
} |
} |
} |
+ if( zFault ){ |
+ sqlite3DbFree(db, zErr); |
+ zErr = sqlite3MPrintf(db, "cannot open %s column for writing", zFault); |
+ rc = SQLITE_ERROR; |
+ sqlite3BtreeLeaveAll(db); |
+ goto blob_open_out; |
+ } |
} |
- v = sqlite3VdbeCreate(db); |
- if( v ){ |
+ pBlob->pStmt = (sqlite3_stmt *)sqlite3VdbeCreate(db); |
+ assert( pBlob->pStmt || db->mallocFailed ); |
+ if( pBlob->pStmt ){ |
+ Vdbe *v = (Vdbe *)pBlob->pStmt; |
int iDb = sqlite3SchemaToIndex(db, pTab->pSchema); |
+ |
sqlite3VdbeAddOpList(v, sizeof(openBlob)/sizeof(VdbeOpList), openBlob); |
- flags = !!flags; /* flags = (flags ? 1 : 0); */ |
+ |
/* Configure the OP_Transaction */ |
sqlite3VdbeChangeP1(v, 0, iDb); |
@@ -178,15 +266,20 @@ int sqlite3_blob_open( |
/* Configure the OP_VerifyCookie */ |
sqlite3VdbeChangeP1(v, 1, iDb); |
sqlite3VdbeChangeP2(v, 1, pTab->pSchema->schema_cookie); |
+ sqlite3VdbeChangeP3(v, 1, pTab->pSchema->iGeneration); |
/* Make sure a mutex is held on the table to be accessed */ |
sqlite3VdbeUsesBtree(v, iDb); |
/* Configure the OP_TableLock instruction */ |
+#ifdef SQLITE_OMIT_SHARED_CACHE |
+ sqlite3VdbeChangeToNoop(v, 2, 1); |
+#else |
sqlite3VdbeChangeP1(v, 2, iDb); |
sqlite3VdbeChangeP2(v, 2, pTab->tnum); |
sqlite3VdbeChangeP3(v, 2, flags); |
sqlite3VdbeChangeP4(v, 2, pTab->zName, P4_TRANSIENT); |
+#endif |
/* Remove either the OP_OpenWrite or OpenRead. Set the P2 |
** parameter of the other to pTab->tnum. */ |
@@ -208,66 +301,25 @@ int sqlite3_blob_open( |
} |
} |
+ pBlob->flags = flags; |
+ pBlob->iCol = iCol; |
+ pBlob->db = db; |
sqlite3BtreeLeaveAll(db); |
- rc = sqlite3SafetyOff(db); |
- if( NEVER(rc!=SQLITE_OK) || db->mallocFailed ){ |
- goto blob_open_out; |
- } |
- |
- sqlite3_bind_int64((sqlite3_stmt *)v, 1, iRow); |
- rc = sqlite3_step((sqlite3_stmt *)v); |
- if( rc!=SQLITE_ROW ){ |
- nAttempt++; |
- rc = sqlite3_finalize((sqlite3_stmt *)v); |
- sqlite3DbFree(db, zErr); |
- zErr = sqlite3MPrintf(db, sqlite3_errmsg(db)); |
- v = 0; |
- } |
- } while( nAttempt<5 && rc==SQLITE_SCHEMA ); |
- |
- if( rc==SQLITE_ROW ){ |
- /* The row-record has been opened successfully. Check that the |
- ** column in question contains text or a blob. If it contains |
- ** text, it is up to the caller to get the encoding right. |
- */ |
- Incrblob *pBlob; |
- u32 type = v->apCsr[0]->aType[iCol]; |
- |
- if( type<12 ){ |
- sqlite3DbFree(db, zErr); |
- zErr = sqlite3MPrintf(db, "cannot open value of type %s", |
- type==0?"null": type==7?"real": "integer" |
- ); |
- rc = SQLITE_ERROR; |
- goto blob_open_out; |
- } |
- pBlob = (Incrblob *)sqlite3DbMallocZero(db, sizeof(Incrblob)); |
if( db->mallocFailed ){ |
- sqlite3DbFree(db, pBlob); |
goto blob_open_out; |
} |
- pBlob->flags = flags; |
- pBlob->pCsr = v->apCsr[0]->pCursor; |
- sqlite3BtreeEnterCursor(pBlob->pCsr); |
- sqlite3BtreeCacheOverflow(pBlob->pCsr); |
- sqlite3BtreeLeaveCursor(pBlob->pCsr); |
- pBlob->pStmt = (sqlite3_stmt *)v; |
- pBlob->iOffset = v->apCsr[0]->aOffset[iCol]; |
- pBlob->nByte = sqlite3VdbeSerialTypeLen(type); |
- pBlob->db = db; |
- *ppBlob = (sqlite3_blob *)pBlob; |
- rc = SQLITE_OK; |
- }else if( rc==SQLITE_OK ){ |
- sqlite3DbFree(db, zErr); |
- zErr = sqlite3MPrintf(db, "no such rowid: %lld", iRow); |
- rc = SQLITE_ERROR; |
- } |
+ sqlite3_bind_int64(pBlob->pStmt, 1, iRow); |
+ rc = blobSeekToRow(pBlob, iRow, &zErr); |
+ } while( (++nAttempt)<5 && rc==SQLITE_SCHEMA ); |
blob_open_out: |
- if( v && (rc!=SQLITE_OK || db->mallocFailed) ){ |
- sqlite3VdbeFinalize(v); |
+ if( rc==SQLITE_OK && db->mallocFailed==0 ){ |
+ *ppBlob = (sqlite3_blob *)pBlob; |
+ }else{ |
+ if( pBlob && pBlob->pStmt ) sqlite3VdbeFinalize((Vdbe *)pBlob->pStmt); |
+ sqlite3DbFree(db, pBlob); |
} |
- sqlite3Error(db, rc, zErr); |
+ sqlite3Error(db, rc, (zErr ? "%s" : 0), zErr); |
sqlite3DbFree(db, zErr); |
sqlite3StackFree(db, pParse); |
rc = sqlite3ApiExit(db, rc); |
@@ -311,7 +363,7 @@ static int blobReadWrite( |
Vdbe *v; |
sqlite3 *db; |
- if( p==0 ) return SQLITE_MISUSE; |
+ if( p==0 ) return SQLITE_MISUSE_BKPT; |
db = p->db; |
sqlite3_mutex_enter(db->mutex); |
v = (Vdbe*)p->pStmt; |
@@ -320,7 +372,7 @@ static int blobReadWrite( |
/* Request is out of range. Return a transient error. */ |
rc = SQLITE_ERROR; |
sqlite3Error(db, SQLITE_ERROR, 0); |
- } else if( v==0 ){ |
+ }else if( v==0 ){ |
/* If there is no statement handle, then the blob-handle has |
** already been invalidated. Return SQLITE_ABORT in this case. |
*/ |
@@ -368,7 +420,47 @@ int sqlite3_blob_write(sqlite3_blob *pBlob, const void *z, int n, int iOffset){ |
*/ |
int sqlite3_blob_bytes(sqlite3_blob *pBlob){ |
Incrblob *p = (Incrblob *)pBlob; |
- return p ? p->nByte : 0; |
+ return (p && p->pStmt) ? p->nByte : 0; |
+} |
+ |
+/* |
+** Move an existing blob handle to point to a different row of the same |
+** database table. |
+** |
+** If an error occurs, or if the specified row does not exist or does not |
+** contain a blob or text value, then an error code is returned and the |
+** database handle error code and message set. If this happens, then all |
+** subsequent calls to sqlite3_blob_xxx() functions (except blob_close()) |
+** immediately return SQLITE_ABORT. |
+*/ |
+int sqlite3_blob_reopen(sqlite3_blob *pBlob, sqlite3_int64 iRow){ |
+ int rc; |
+ Incrblob *p = (Incrblob *)pBlob; |
+ sqlite3 *db; |
+ |
+ if( p==0 ) return SQLITE_MISUSE_BKPT; |
+ db = p->db; |
+ sqlite3_mutex_enter(db->mutex); |
+ |
+ if( p->pStmt==0 ){ |
+ /* If there is no statement handle, then the blob-handle has |
+ ** already been invalidated. Return SQLITE_ABORT in this case. |
+ */ |
+ rc = SQLITE_ABORT; |
+ }else{ |
+ char *zErr; |
+ rc = blobSeekToRow(p, iRow, &zErr); |
+ if( rc!=SQLITE_OK ){ |
+ sqlite3Error(db, rc, (zErr ? "%s" : 0), zErr); |
+ sqlite3DbFree(db, zErr); |
+ } |
+ assert( rc!=SQLITE_SCHEMA ); |
+ } |
+ |
+ rc = sqlite3ApiExit(db, rc); |
+ assert( rc==SQLITE_OK || p->pStmt==0 ); |
+ sqlite3_mutex_leave(db->mutex); |
+ return rc; |
} |
#endif /* #ifndef SQLITE_OMIT_INCRBLOB */ |