Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 6990046: Register with Keystone using a versionPath and versionKey (Closed)

Created:
9 years, 7 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Register with Keystone using a versionPath and versionKey. Providing this data to Keystone will cause it to check the application's Info.plist to determine the installed version, rather than using the version embedded within the ticket. The version in the ticket can become stale in some rare situations through innocent user action. This allows a user to replace Chrome with an earlier version (perhaps on another channel) and not get "stuck" without autoupdates until that channel catches up with the version listed in the ticket. (b/2506062) This also prevents Keystone from believing an update is still available if Chrome is updated but not restarted and the user subsequently promotes Chrome's user ticket to a system ticket from within Chrome. (crbug.com/38696) BUG=38696 TEST=On a user ticket, ksadmin -p should show a versionPath and versionKey after Chrome is launched. If promoted to a system ticket, ksadmin -Sp should show these same two parameters. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86387

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/browser/cocoa/keystone_glue.mm View 1 10 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
9 years, 7 months ago (2011-05-23 21:41:16 UTC) #1
TVL
9 years, 7 months ago (2011-05-24 01:34:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698