Issue 6990040: [ChromeOS] Fix network dialog width issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990040: [ChromeOS] Fix network dialog width issues. (Closed)

Created:
9 years, 7 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
Charlie Lee

CC:
chromium-reviews, finnur+watch_chromium.org, davemoore+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[ChromeOS] Fix network dialog width issues. - Add a IDS_JOIN_WIFI_NETWORK_DIALOG_ADVANCED_WIDTH_CHARS and use that to make advanced network dialog big enough for fr and es. - Make basic network dialog width smaller for a better fit per chromium-os:15660; BUG=chromium-os:15488, chromium-os:15660 TEST=Verify fix for chromium-os:15488 and chromium-os:15660 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86429

Patch Set 1 #

Patch Set 2 : make basic wifi dialog smaller for better fit and increased es advanced width #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	chrome/app/resources/locale_settings.grd	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/app/resources/locale_settings_es.xtb	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/app/resources/locale_settings_fr.xtb	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages