Deciding best connection to schedule requests on based on cwnd and idle time

chrome/browser/browser_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 82 matching lines @@
 #include "content/common/hi_res_timer_manager.h"
 #include "content/common/main_function_params.h"
 #include "content/common/result_codes.h"
 #include "grit/app_locale_settings.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/platform_locale_settings.h"
 #include "net/base/cookie_monster.h"
 #include "net/base/net_module.h"
 #include "net/base/network_change_notifier.h"
+#include "net/http/http_basic_stream.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_stream_factory.h"
 #include "net/socket/client_socket_pool_base.h"
 #include "net/socket/client_socket_pool_manager.h"
 #include "net/socket/tcp_client_socket.h"
 #include "net/spdy/spdy_session.h"
 #include "net/spdy/spdy_session_pool.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_throttler_manager.h"
 #include "net/websockets/websocket_job.h"
@@ skipping 87 matching lines @@
 #endif
 
 #if defined(TOOLKIT_USES_GTK)
 #include "ui/gfx/gtk_util.h"
 #endif
 
 #if defined(TOUCH_UI) && defined(HAVE_XINPUT2)
 #include "views/touchui/touch_factory.h"
 #endif
 
+using net::internal::ClientSocketPoolBaseHelper;
+using net::HttpBasicStream;
+
 namespace net {
 class NetLog;
 }  // namespace net
 
 // BrowserMainParts ------------------------------------------------------------
 
 BrowserMainParts::BrowserMainParts(const MainFunctionParams& parameters)
     : parameters_(parameters),
       parsed_command_line_(parameters.command_line_) {
 }
@@ skipping 247 matching lines @@
   if (parsed_command_line().HasSwitch(switches::kMaxSpdyConcurrentStreams)) {
     int value = 0;
     base::StringToInt(parsed_command_line().GetSwitchValueASCII(
             switches::kMaxSpdyConcurrentStreams),
         &value);
     if (value > 0)
       net::SpdySession::set_max_concurrent_streams(value);
   }
 }
 
+// If --bytes-read-vs-last-accessed-decay-coef is not specified, run an A/B
+// test for choosing the warmest socket.
+void BrowserMainParts::WarmConnectionFieldTrial() {
+  const CommandLine& command_line = parsed_command_line();
+  if (command_line.HasSwitch(switches::kTcpSocketEstimatedCwndDecayCoef)) {
+    std::string alpha_str = command_line.GetSwitchValueASCII(
+        switches::kTcpSocketEstimatedCwndDecayCoef);
+    double coef = 0;
+    base::StringToDouble(alpha_str, &coef);
+    ClientSocketPoolBaseHelper::set_tcp_socket_estimated_cwnd_decay_coef(
+        coef);
+    HttpBasicStream::set_warm_connection_field_trial_group("manual");
+    return;
+  }
+
+  const base::FieldTrial::Probability kWarmSocketDivisor = 100;
+  const base::FieldTrial::Probability kWarmSocketProbability = 33;  // 1% prob.

[Mike Belshe, 2011/06/09 16:08:52]

The comment is wrong here

[Gagan, 2011/06/09 19:49:26]

Done.

+
+  // After January 30, 2013 builds, it will always be in default group.
+  scoped_refptr<base::FieldTrial> warmest_socket_trial(
+      new base::FieldTrial(
+          "WarmSocketImpact", kWarmSocketDivisor, "last_accessed_socket",
+          2013, 1, 30));
+
+  // This (1000000) is the current default value.

[Mike Belshe, 2011/06/09 16:08:52]

I think the comment is wrong here too?

[Gagan, 2011/06/09 19:49:26]

Done.

+  const int last_accessed_socket = warmest_socket_trial->kDefaultGroupNumber;
+  const int warmest_socket = warmest_socket_trial->AppendGroup(
+      "warmest_socket", kWarmSocketProbability);
+  const int warm_socket = warmest_socket_trial->AppendGroup(
+      "warm_socket", kWarmSocketProbability);
+
+  const int warmest_socket_trial_group = warmest_socket_trial->group();
+
+  if (warmest_socket_trial_group == last_accessed_socket) {
+    ClientSocketPoolBaseHelper::set_tcp_socket_estimated_cwnd_decay_coef(

[Mike Belshe, 2011/06/09 16:08:52]

This seems like a strange place to set the policy.

I would have preferred that the ClientSocketPoolBaseHelper have:

enum {
   USE_WARMEST_SOCKET,
   USE_WARM_SOCKET,
   USE_LAST_SOCKET
} ClientSocketReusePolicy;

and then

SetSocketReusePolicy(USE_WARMEST_SOCKET)

would internally do:
   set_tcp_socket_estimated_cwnd_decay_coef(1000000)

In other words, the reader of code here in browser main shouldn't need to know
the guts of policy decisions deep inside the socket code.

[Gagan, 2011/06/09 19:49:26]

Done.

+        1000000);
+    HttpBasicStream::set_warm_connection_field_trial_group(
+        "last_accessed_socket");
+  } else if (warmest_socket_trial_group == warmest_socket) {
+    ClientSocketPoolBaseHelper::set_tcp_socket_estimated_cwnd_decay_coef(
+        1);
+    HttpBasicStream::set_warm_connection_field_trial_group(
+        "warmest_socket");
+  } else if (warmest_socket_trial_group == warm_socket) {
+    // 1.83841629 = decay of 20 KB per 5 mins.
+    ClientSocketPoolBaseHelper::set_tcp_socket_estimated_cwnd_decay_coef(
+        1.83841629);
+    HttpBasicStream::set_warm_connection_field_trial_group(
+        "warm_socket");
+  } else {
+    NOTREACHED() << "Invalid bytes_read_vs_last_accessed_alpha";
+  }
+}
+
+
 // If neither --enable-connect-backup-jobs or --disable-connect-backup-jobs is
 // specified, run an A/B test for automatically establishing backup TCP
 // connections when a certain timeout value is exceeded.
 void BrowserMainParts::ConnectBackupJobsFieldTrial() {
   if (parsed_command_line().HasSwitch(switches::kEnableConnectBackupJobs)) {
     net::internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(
         true);
   } else if (parsed_command_line().HasSwitch(
         switches::kDisableConnectBackupJobs)) {
     net::internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(
@@ skipping 99 matching lines @@
     chrome_browser_net_websocket_experiment::WebSocketExperimentRunner::Start();
 
   // Note: make sure to call ConnectionFieldTrial() before
   // ProxyConnectionsFieldTrial().
   ConnectionFieldTrial();
   SocketTimeoutFieldTrial();
   ProxyConnectionsFieldTrial();
   prerender::ConfigurePrefetchAndPrerender(parsed_command_line());
   SpdyFieldTrial();
   ConnectBackupJobsFieldTrial();
+  WarmConnectionFieldTrial();
 }
 
 // -----------------------------------------------------------------------------
 // TODO(viettrungluu): move more/rest of BrowserMain() into above structure
 
 namespace {
 
 // This function provides some ways to test crash and assertion handling
 // behavior of the program.
 void HandleTestParameters(const CommandLine& command_line) {
@@ skipping 1364 matching lines @@
 #if defined(OS_CHROMEOS)
   // To be precise, logout (browser shutdown) is not yet done, but the
   // remaining work is negligible, hence we say LogoutDone here.
   chromeos::BootTimesLoader::Get()->AddLogoutTimeMarker("LogoutDone",
                                                         false);
   chromeos::BootTimesLoader::Get()->WriteLogoutTimes();
 #endif
   TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
   return result_code;
 }