Issue 6990028: Remove files that don't exist, and fix typos in gyp files

Issue 6990028: Remove files that don't exist, and fix typos in gyp files (Closed)

Created:
9 years, 7 months ago by sadrul

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google), Wez, willchan no longer on Chromium

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, Jói, wez+watch_chromium.org, jam, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove files that don't exist, and fix typos in gyp files BUG=none TEST=things still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86533

Patch Set 1 #

Patch Set 2 : some more #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -79 lines)			Patch
M	base/base.gyp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/base.gypi	View	1	2 chunks	+1 line, -6 lines	0 comments	Download
M	breakpad/breakpad.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	15 chunks	+6 lines, -39 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	4 chunks	+0 lines, -8 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View	1	3 chunks	+0 lines, -9 lines	0 comments	Download
M	remoting/remoting.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/skia.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	views/views.gyp	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

I've looked at base/ and net/. They lgtm. I leave the rest to Ben. Cheers ...

9 years, 7 months ago (2011-05-23 20:48:03 UTC) #2

Wez

On 2011/05/23 20:48:03, willchan wrote: > I've looked at base/ and net/. They lgtm. > ...

9 years, 7 months ago (2011-05-23 22:25:38 UTC) #3

Ben Goodger (Google)

9 years, 7 months ago (2011-05-24 21:50:46 UTC) #5

Yes.LGTM I thought I LGTMed this earlier. Sorry :-)

-Ben

On Tue, May 24, 2011 at 2:48 PM, <sadrul@chromium.org> wrote:

> @ben: LGTY?
>
>
> http://codereview.chromium.org/6990028/
>

Expand Messages | Collapse Messages