Issue 6990019: Remove override on thread IO restrictions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990019: Remove override on thread IO restrictions. (Closed)

Created:
9 years, 7 months ago by wjmaclean

Modified:
9 years, 7 months ago

Reviewers:
beng (no_code_reviews), sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove override on thread IO restrictions. This is the removal of code to disable security restrictions on disk IO, originally needed so that the GL bindings could be initialized. The GL libraries now manage this in a separate thread with the necessary permissions. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86186

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove associated include file. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	ui/gfx/compositor/compositor_gl.cc	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/6990019/diff/1/ui/gfx/compositor/compositor_gl.cc File ui/gfx/compositor/compositor_gl.cc (left): http://codereview.chromium.org/6990019/diff/1/ui/gfx/compositor/compositor_gl.cc#oldcode249 ui/gfx/compositor/compositor_gl.cc:249: base::ThreadRestrictions::ScopedAllowIO allow_io; Is there a corresponding include that ...

9 years, 7 months ago (2011-05-20 21:42:47 UTC) #2

wjmaclean

9 years, 7 months ago (2011-05-20 21:49:15 UTC) #3

On 2011/05/20 21:42:47, sky wrote:
> LGTM
> 
>
http://codereview.chromium.org/6990019/diff/1/ui/gfx/compositor/compositor_gl.cc
> File ui/gfx/compositor/compositor_gl.cc (left):
> 
>
http://codereview.chromium.org/6990019/diff/1/ui/gfx/compositor/compositor_gl...
> ui/gfx/compositor/compositor_gl.cc:249:
base::ThreadRestrictions::ScopedAllowIO
> allow_io;
> Is there a corresponding include that can be nuked?

Yup, thanks for the reminder!

Expand Messages | Collapse Messages