Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 6990008: LBYL on GSettings (Closed)

Created:
9 years, 7 months ago by jonathan.backer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

LBYL on GSettings Fixes a regression from r85968. On my Ubuntu 10.10 box, g_settings_new does not fail gracefully if the schema is not found: it calls an assert. This checks if the schema exists first. The docs for g_settings_list_schemas specify not to modify or release the return value. BUG=83376 TEST=by hand and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M net/proxy/proxy_config_service_linux.cc View 5 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jonathan.backer
9 years, 7 months ago (2011-05-20 18:43:04 UTC) #1
Mike Mammarella
On 2011/05/20 18:43:04, jonathan.backer wrote: LGTM, thanks!
9 years, 7 months ago (2011-05-20 18:50:10 UTC) #2
dbpalma9_gmail.com
How do I patch chromium? Sorry for my ignorance.
9 years, 7 months ago (2011-05-20 18:58:56 UTC) #3
vandebo (ex-Chrome)
LGTM
9 years, 7 months ago (2011-05-20 19:01:17 UTC) #4
commit-bot: I haz the power
Change committed as 86140
9 years, 7 months ago (2011-05-20 20:30:28 UTC) #5
sebastian.farias_gmail.com
On 2011/05/20 20:30:28, commit-bot wrote: > Change committed as 86140 hi, how to path? tnks...
9 years, 7 months ago (2011-05-23 02:33:37 UTC) #6
sebastian.farias_gmail.com
On 2011/05/20 18:43:04, jonathan.backer wrote: Hi... how to apply this path? thnx
9 years, 7 months ago (2011-05-24 05:21:53 UTC) #7
jonathan.backer
9 years, 7 months ago (2011-05-24 12:42:43 UTC) #8
You can use the "Download raw patch set" link above to save a patch. Then in the
root of your Chromium source directory (usually chromium/src) run:

patch -p1 < path/to/downloaded/patch/filename

I often run the patch command with a --dry-run option first to see if it
succeeds, because if it fails it will leave .rej files in your source directory.
Rarely, it's necessary to change the -p1 option to a -p0 or -p2

On 2011/05/24 05:21:53, sebastian.farias wrote:
> On 2011/05/20 18:43:04, jonathan.backer wrote:
> 
> Hi... how to apply this path?
> 
> thnx

Powered by Google App Engine
This is Rietveld 408576698