Issue 6990002: Fix ringbuffer test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6990002: Fix ringbuffer test. (Closed)

Created:
9 years, 7 months ago by jbauman

Modified:
9 years, 7 months ago

Reviewers:
greggman, commit-bot: I haz the power, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix ringbuffer test. The SetToken mock was using the command header as the token value. Also, the ringbuffer test didn't support the jump command, so if the number of entries in the command buffer is too small then the test breaks. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86167

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
	M	gpu/command_buffer/client/ring_buffer_test.cc	View		4 chunks	+25 lines, -0 lines	0 comments	Download
	M	gpu/command_buffer/service/mocks.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 86167

Expand Messages | Collapse Messages