Misc. infobar stuff:

Misc. infobar stuff:
  * Move the cross-platform parts of InfoBar and InfoBarContainer to chrome/browser/tab_contents (but place them under a TOOLKIT_VIEWS #ifdef until other platforms are ported).
  * Plumb the "owning" TabContentsWrapper* through the infobar creation APIs.  Ultimately the InfoBar will use this (when TabContents actually starts owning InfoBar*s), but for now it just stores it as an unused member.
  * A few random other small changes.

BUG=62154
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86450

[sky, 2011-05-09 22:56:39]

LGTM

http://codereview.chromium.org/6989001/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_metrics_unittest.cc (right):

http://codereview.chromium.org/6989001/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics_unittest.cc:223: CreditCard*
credit_card = new CreditCard();
How about a comment about ownership of CreditCard?

http://codereview.chromium.org/6989001/diff/1/chrome/browser/tab_contents/inf...
File chrome/browser/tab_contents/infobar.cc (right):

http://codereview.chromium.org/6989001/diff/1/chrome/browser/tab_contents/inf...
chrome/browser/tab_contents/infobar.cc:124: static_cast<int>(bar_target_height_
* animation_->GetCurrentValue());
This should use Tween::ValueBetween

[Peter Kasting, 2011-05-09 23:23:33]

Will land once trybots are clean.

http://codereview.chromium.org/6989001/diff/1/chrome/browser/autofill/autofil...
File chrome/browser/autofill/autofill_metrics_unittest.cc (right):

http://codereview.chromium.org/6989001/diff/1/chrome/browser/autofill/autofil...
chrome/browser/autofill/autofill_metrics_unittest.cc:223: CreditCard*
credit_card = new CreditCard();
On 2011/05/09 22:56:39, sky wrote:
> How about a comment about ownership of CreditCard?

Sure.

http://codereview.chromium.org/6989001/diff/1/chrome/browser/tab_contents/inf...
File chrome/browser/tab_contents/infobar.cc (right):

http://codereview.chromium.org/6989001/diff/1/chrome/browser/tab_contents/inf...
chrome/browser/tab_contents/infobar.cc:124: static_cast<int>(bar_target_height_
* animation_->GetCurrentValue());
On 2011/05/09 22:56:39, sky wrote:
> This should use Tween::ValueBetween

Or even better, Animation::CurrentValueBetween().  Changed.