Fix GC-unsafe corner case in bit-not on ARM

Fix GC-unsafe corner case in bit-not on ARM
Committed: http://code.google.com/p/v8/source/detail?r=8055

[Lasse Reichstein, 2011-05-25 08:44:49]

LGTM with negation.

http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1929: __ push(r0);  // Push the heap number, not the
untagged int32.
Are you sure that AllocateHeapNumber above doesn't clobber r0 if it fails to
allocate? (If so, make a comment to that effect).

http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1938: __ ConvertToInt32(r2, r1, r3, r4, d0, slow);
Don't forget to negate the result.
(If this isn't caught by a test, maybe we need one).

http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:1949: __ vstr(d0, r2, HeapNumber::kValueOffset);
Shouldn't this just be 
  __ vstr(d0, r0, HeapNumber::kValueOffset - kHeapObjectTag)?
Or should vstr take a MemOperand?

[Lasse Reichstein, 2011-05-25 10:29:39]

LGTM

http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js
File test/mjsunit/bit-not.js (right):

http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js#newc...
test/mjsunit/bit-not.js:72: eval("");
Are we sure Crankshaft will never support eval? Especially with constant strings
(obvious inlining opportunity)?

[Erik Corry, 2011-05-25 10:34:40]

http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js
File test/mjsunit/bit-not.js (right):

http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js#newc...
test/mjsunit/bit-not.js:72: eval("");
On 2011/05/25 10:29:39, Lasse Reichstein wrote:
> Are we sure Crankshaft will never support eval? Especially with constant
strings
> (obvious inlining opportunity)?

I will make it my mission to ensure that Crankshaft never supports eval :-)