Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 6987009: Fix GC-unsafe corner case in bit-not on ARM (Closed)

Created:
9 years, 7 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix GC-unsafe corner case in bit-not on ARM Committed: http://code.google.com/p/v8/source/detail?r=8055

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/arm/code-stubs-arm.cc View 1 3 chunks +21 lines, -4 lines 0 comments Download
M test/mjsunit/binary-op-newspace.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/bit-not.js View 1 2 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 7 months ago (2011-05-25 08:31:35 UTC) #1
Lasse Reichstein
LGTM with negation. http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6987009/diff/1/src/arm/code-stubs-arm.cc#newcode1929 src/arm/code-stubs-arm.cc:1929: __ push(r0); // Push the heap ...
9 years, 7 months ago (2011-05-25 08:44:49 UTC) #2
Lasse Reichstein
LGTM http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js File test/mjsunit/bit-not.js (right): http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js#newcode72 test/mjsunit/bit-not.js:72: eval(""); Are we sure Crankshaft will never support ...
9 years, 7 months ago (2011-05-25 10:29:39 UTC) #3
Erik Corry
9 years, 7 months ago (2011-05-25 10:34:40 UTC) #4
http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js
File test/mjsunit/bit-not.js (right):

http://codereview.chromium.org/6987009/diff/2003/test/mjsunit/bit-not.js#newc...
test/mjsunit/bit-not.js:72: eval("");
On 2011/05/25 10:29:39, Lasse Reichstein wrote:
> Are we sure Crankshaft will never support eval? Especially with constant
strings
> (obvious inlining opportunity)?

I will make it my mission to ensure that Crankshaft never supports eval :-)

Powered by Google App Engine
This is Rietveld 408576698