iwyu: Use callback_old.h where appropriate, part 1.

iwyu: Use callback_old.h where appropriate, part 1.

BUG=none
TEST=none

R=thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84725

[Nico, 2011-05-09 23:22:36]

+awong; I'm not sure what the callback transition plan is.

[awong, 2011-05-09 23:29:21]

The hope is to move the callsites to the new method after we've gotten a few
modules ported over and shaken out any bugs.  I'm not sure it's worth the
churn to change all the #includes.

What's the motivation behind this CL?

-Albert

On Mon, May 9, 2011 at 4:22 PM, <thakis@chromium.org> wrote:

> +awong; I'm not sure what the callback transition plan is.
>
>
> http://codereview.chromium.org/6985009/
>

[James Hawkins, 2011-05-09 23:31:35]

I'm iwyu-ing all of base/ as a precursor to a larger iwyu effort in Chrome
proper. Assuming at some point in time we turn on iwyu for Chrome (presubmit
most likely), this will have to be fixed. Since I'm putting in the effort, I
don't see the harm.

On 2011/05/09 23:29:21, awong wrote:
> The hope is to move the callsites to the new method after we've gotten a few
> modules ported over and shaken out any bugs.  I'm not sure it's worth the
> churn to change all the #includes.
> 
> What's the motivation behind this CL?
> 
> -Albert
> 
> On Mon, May 9, 2011 at 4:22 PM, <mailto:thakis@chromium.org> wrote:
> 
> > +awong; I'm not sure what the callback transition plan is.
> >
> >
> > http://codereview.chromium.org/6985009/
> >

[awong, 2011-05-09 23:36:14]

Ah...okay, lgtm.

On Mon, May 9, 2011 at 4:31 PM, <jhawkins@chromium.org> wrote:

> I'm iwyu-ing all of base/ as a precursor to a larger iwyu effort in Chrome
> proper. Assuming at some point in time we turn on iwyu for Chrome
> (presubmit
> most likely), this will have to be fixed. Since I'm putting in the effort,
> I
> don't see the harm.
>
>
> On 2011/05/09 23:29:21, awong wrote:
>
>> The hope is to move the callsites to the new method after we've gotten a
>> few
>> modules ported over and shaken out any bugs.  I'm not sure it's worth the
>> churn to change all the #includes.
>>
>
>  What's the motivation behind this CL?
>>
>
>  -Albert
>>
>
>  On Mon, May 9, 2011 at 4:22 PM, <mailto:thakis@chromium.org> wrote:
>>
>
>  > +awong; I'm not sure what the callback transition plan is.
>> >
>> >
>> > http://codereview.chromium.org/6985009/
>> >
>>
>
>
>
> http://codereview.chromium.org/6985009/
>

[Nico, 2011-05-09 23:36:58]

LGTM from me too, then.