Issue 6982059: Reduce TLS overhead in v8::TryCatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6982059: Reduce TLS overhead in v8::TryCatch. (Closed)

Created:
9 years, 6 months ago by Vitaly Repeshko

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Reduce TLS overhead in v8::TryCatch. R=vegorov@chromium.org BUG=v8:1426 Committed: http://code.google.com/p/v8/source/detail?r=8208

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	src/api.cc	View		5 chunks	+19 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM though I am bit concerned about using value of an internal type in the ...

9 years, 6 months ago (2011-06-07 14:58:26 UTC) #2

Vitaly Repeshko

9 years, 6 months ago (2011-06-07 15:01:29 UTC) #3

Thanks!

http://codereview.chromium.org/6982059/diff/4/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/6982059/diff/4/include/v8.h#newcode3262
include/v8.h:3262: v8::internal::Isolate* isolate_;
On 2011/06/07 14:58:26, Vyacheslav Egorov wrote:
> I think it's the first time when we actually use value of type
> v8::internal::Isolate* in the v8.h.
> 
> Maybe we should use void* instead?

We already use it in a few places. It doesn't really expose much since it's just
a pointer.

Expand Messages | Collapse Messages