Draw a NativeTextfieldViews drop location cursor.

Draw a NativeTextfieldViews drop location cursor.
Move GetCursorBounds to NativeTextfieldViews.
Some minor refactoring.

BUG=72040
TEST=--use-pure-views textfield cursor showing drop location.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88618

[msw, 2011-06-07 00:52:56]

Please take a look.

[oshima, 2011-06-07 17:32:52]

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
File views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
views/controls/textfield/native_textfield_views.cc:768: DCHECK(x >= 0);
can you change to DCHECK_GE?

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
views/controls/textfield/native_textfield_views.cc:864:
drop_cursor_bounds_.height());
basic question. Can both be visible at the same time?
I'm guessing that regular cursor isn't visible while
dragging so we dont need another bounds, no?

[msw, 2011-06-08 23:50:29]

PTAL. Comments addressed, and I fixed the cursor position for when the text
offset is non-zero.

Unfortunately, you can't drag to pan beyond the visible text range right now,
but that can be addressed later.

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
File views/controls/textfield/native_textfield_views.cc (right):

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
views/controls/textfield/native_textfield_views.cc:768: DCHECK(x >= 0);
On 2011/06/07 17:32:52, oshima wrote:
> can you change to DCHECK_GE?

Done.

http://codereview.chromium.org/6982055/diff/6/views/controls/textfield/native...
views/controls/textfield/native_textfield_views.cc:864:
drop_cursor_bounds_.height());
On 2011/06/07 17:32:52, oshima wrote:
> basic question. Can both be visible at the same time?
> I'm guessing that regular cursor isn't visible while
> dragging so we dont need another bounds, no?

Done.

[oshima, 2011-06-09 23:48:31]

LGTM