Reset sync setup dialog to initial state when it is opened.

chrome/browser/resources/options/sync_setup_overlay.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
 
   // Variable to track if a captcha challenge was issued. If this gets set to
   // true, it stays that way until we are told about successful login from
   // the browser.  This means subsequent errors (like invalid password) are
@@ skipping 173 matching lines @@
           }
         }
       }
 
       return atLeastOneEnabled && !atLeastOneChecked;
     },
 
     checkPassphraseMatch_: function() {
       var emptyError = $('empty-error');
       var mismatchError = $('mismatch-error');
-      emptyError.style.display = "none";
-      mismatchError.style.display = "none";
+      emptyError.hidden = true;
+      mismatchError.hidden = true;
 
       var f = $('choose-data-types-form');
       if (this.getPassphraseRadioCheckedValue_() != "explicit" ||
           f.option[0].disabled)
         return true;
 
       var customPassphrase = $('custom-passphrase');
       if (customPassphrase.value.length == 0) {
-        emptyError.style.display = "block";
+        emptyError.hidden = false;
         return false;
       }
 
       var confirmPassphrase = $('confirm-passphrase');
       if (confirmPassphrase.value != customPassphrase.value) {
-        mismatchError.style.display = "block";
+        mismatchError.hidden = false;
         return false;
       }
 
       return true;
     },
 
     sendConfiguration_: function() {
       // Trying to submit, so hide previous errors.
       $('aborted-text').className = "sync-error-hide";
       $('error-text').className = "sync-error-hide";
@@ skipping 279 matching lines @@
       else
         this.showOverlay_();
     },
 
     setThrobbersVisible_: function(visible) {
       var throbbers = document.getElementsByClassName("throbber");
         for (var i = 0; i < throbbers.length; i++)
           throbbers[i].style.visibility = visible ? "visible" : "hidden";
     },
 
-    setElementDisplay_: function(id, display) {
-      var d = document.getElementById(id);
-      if (d)
-        d.style.display = display;
-    },
-
     loginSetFocus_: function() {
       var email = $('gaia-email');
       var passwd = $('gaia-passwd');
       if (email && (email.value == null || email.value == "")) {
         email.focus();
       } else if (passwd) {
         passwd.focus();
       }
     },
 
     showAccessCodeRequired_: function() {
-      this.setElementDisplay_("password-row", "none");
-      this.setElementDisplay_("email-row", "none");
+      $('password-row').hidden = true;
+      $('email-row').hidden = true;
       $('create-account-cell').style.visibility = "hidden";
 
-      this.setElementDisplay_("access-code-label-row", "table-row");
-      this.setElementDisplay_("access-code-input-row", "table-row");
-      this.setElementDisplay_("access-code-help-row", "table-row");
-      document.getElementById('access-code').disabled = false;
+      $('access-code-label-row').hidden = false;
+      $('access-code-input-row').hidden = false;
+      $('access-code-help-row').hidden = false;
+      $('access-code').disabled = false;
     },
 
     showCaptcha_: function(args) {
       this.captchaChallengeActive_ = true;
 
       // The captcha takes up lots of space, so make room.
-      this.setElementDisplay_("top-blurb", "none");
-      this.setElementDisplay_("top-blurb-error", "none");
-      this.setElementDisplay_("create-account-div", "none");
-      document.getElementById('create-account-cell').height = 0;
+      $('top-blurb-error').hidden = true;
+      $('create-account-div').hidden = true;
+      $('create-account-cell').hidden = true;
 
       // It's showtime for the captcha now.
-      this.setElementDisplay_("captcha-div", "block");
-      document.getElementById('gaia-email').disabled = true;
-      document.getElementById('gaia-passwd').disabled = false;
-      document.getElementById('captcha-value').disabled = false;
-      document.getElementById('captcha-wrapper').style.backgroundImage =
-          url(args.captchaUrl);
+      $('captcha-div').hidden = false;
+      $('gaia-email').disabled = true;
+      $('gaia-passwd').disabled = false;
+      $('captcha-value').disabled = false;
+      $('captcha-wrapper').style.backgroundImage = url(args.captchaUrl);
+    },
+
+    resetPage_: function(pageElementId) {
+      var page = $(pageElementId);
+      var forEach = function (arr, fn) {

[csilv, 2011/06/03 01:34:54]

style nit: eliminate space before opening parenthesis here and below

+        var length = arr.length;
+        for (var i = 0; i < length; i++) {
+          fn(arr[i]);
+        }
+      };
+
+      forEach(page.getElementsByClassName('reset-hidden'),
+          function (elt) { elt.hidden = true; });
+      forEach(page.getElementsByClassName('reset-shown'),
+          function (elt) { elt.hidden = false; });
+      forEach(page.getElementsByClassName('reset-display-default'),

[csilv, 2011/06/03 01:34:54]

it doesn't look like 'reset-display-default' is ever used... (unless I'm just
missing it.)  if not used, remove it.

+          function (elt) { elt.style.display = ''; });
+      forEach(page.getElementsByClassName('reset-disabled'),
+          function (elt) { elt.disabled = true; });
+      forEach(page.getElementsByClassName('reset-enabled'),
+          function (elt) { elt.disabled = false; });
+      forEach(page.getElementsByClassName('reset-visibility-hidden'),
+          function (elt) { elt.style.visibility = 'hidden'; });
     },
 
     showGaiaLogin_: function(args) {
+      this.resetPage_('sync-setup-login');
       $('sync-setup-login').hidden = false;
 
-      document.getElementById('gaia-email').disabled = false;
-      document.getElementById('gaia-passwd').disabled = false;
-
       var f = $('gaia-login-form');
       var email = $('gaia-email');
       var passwd = $('gaia-passwd');
       if (f) {
         if (args.user != undefined) {
           if (email.value != args.user)
             passwd.value = ""; // Reset the password field
           email.value = args.user;
         }
 
         if (!args.editable_user) {
           email.style.display = 'none';
           var span = document.getElementById('email-readonly');
           span.appendChild(document.createTextNode(email.value));
           span.style.display = 'inline';
-          this.setElementDisplay_("create-account-div", "none");
+          $('create-account-div').hidden = true;
         }
 
         f.accessCode.disabled = true;
       }
 
       if (1 == args.error) {
         var access_code = document.getElementById('access-code');
         if (access_code.value && access_code.value != "") {
-          this.setElementDisplay_("errormsg-0-access-code", 'block');
+          $('errormsg-0-access-code').hidden = false;
           this.showAccessCodeRequired_();
         } else {
-          this.setElementDisplay_("errormsg-1-password", 'table-row');
+          $('errormsg-1-password').hidden = false;
         }
         this.setBlurbError_(args.error_message);
       } else if (3 == args.error) {
-        this.setElementDisplay_("errormsg-0-connection", 'table-row');
+        $('errormsg-0-connection').hidden = false;
         this.setBlurbError_(args.error_message);
       } else if (4 == args.error) {
         this.showCaptcha_(args);
       } else if (8 == args.error) {
         this.showAccessCodeRequired_();
       } else if (args.error_message) {
         this.setBlurbError_(args.error_message);
       }
 
       $('sign-in').disabled = false;
       $('sign-in').value = templateData['signin'];
       this.loginSetFocus_();
     },
 
     resetErrorVisibility_: function() {
-      this.setElementDisplay_("errormsg-0-email", 'none');
-      this.setElementDisplay_("errormsg-0-password", 'none');
-      this.setElementDisplay_("errormsg-1-password", 'none');
-      this.setElementDisplay_("errormsg-0-connection", 'none');
-      this.setElementDisplay_("errormsg-0-access-code", 'none');
+      $("errormsg-0-email").hidden = true;
+      $("errormsg-0-password").hidden = true;
+      $("errormsg-1-password").hidden = true;
+      $("errormsg-0-connection").hidden = true;
+      $("errormsg-0-access-code").hidden = true;
     },
 
     setBlurbError_: function(error_message) {
       if (this.captchaChallengeActive_)
         return;  // No blurb in captcha challenge mode.
 
       if (error_message) {
-        document.getElementById('error-signing-in').style.display = 'none';
-        document.getElementById('error-custom').style.display = 'inline';
-        document.getElementById('error-custom').textContent = error_message;
+        $('error-signing-in').hidden = true;
+        $('error-custom').hidden = false;
+        $('error-custom').textContent = error_message;
       } else {
-        document.getElementById('error-signing-in').style.display = 'inline';
-        document.getElementById('error-custom').style.display = 'none';
+        $('error-signing-in').hidden = false;
+        $('error-custom').hidden = true;
       }
 
       $('top-blurb-error').style.visibility = "visible";
-      document.getElementById('gaia-email').disabled = false;
-      document.getElementById('gaia-passwd').disabled = false;
+      $('gaia-email').disabled = false;
+      $('gaia-passwd').disabled = false;
     },
 
     setErrorVisibility_: function() {
       this.resetErrorVisibility_();
       var f = $('gaia-login-form');
       var email = $('gaia-email');
       var passwd = $('gaia-passwd');
       if (null == email.value || "" == email.value) {
-        this.setElementDisplay_("errormsg-0-email", 'table-row');
+        $('errormsg-0-email').hidden = false;
         this.setBlurbError_();
         return false;
       }
       if (null == passwd.value || "" == passwd.value) {
-        this.setElementDisplay_("errormsg-0-password", 'table-row');
+        $('errormsg-0-password').hidden = false;
         this.setBlurbError_();
         return false;
       }
       if (!f.accessCode.disabled && (null == f.accessCode.value ||
           "" == f.accessCode.value)) {
-        this.setElementDisplay_("errormsg-0-password", 'table-row');
+        $('errormsg-0-password').hidden = false;
         return false;
       }
       return true;
     },
 
     sendCredentialsAndClose_: function() {
       if (!this.setErrorVisibility_()) {
         return false;
       }
 
@@ skipping 54 matching lines @@
 
   SyncSetupOverlay.showSuccessAndSettingUp = function() {
     SyncSetupOverlay.getInstance().showSuccessAndSettingUp_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });