Reset sync setup dialog to initial state when it is opened.

Reset sync setup dialog to initial state when it is opened.

BUG=84542
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87835

[binji, 2011-06-03 00:58:45]

On 2011/06/02 21:49:10, binji wrote:

James suggested that you review this CL because he's out until Tuesday.

[csilv, 2011-06-03 01:34:53]

LGTM, just minor items below.

http://codereview.chromium.org/6982048/diff/6001/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/6982048/diff/6001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:549: var forEach =
function (arr, fn) {
style nit: eliminate space before opening parenthesis here and below

http://codereview.chromium.org/6982048/diff/6001/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:560:
forEach(page.getElementsByClassName('reset-display-default'),
it doesn't look like 'reset-display-default' is ever used... (unless I'm just
missing it.)  if not used, remove it.

[commit-bot: I haz the power, 2011-06-03 17:25:55]

Presubmit check for 6982048-6002 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 34, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1235, in Main
    None)
  File "/b/depot_tools/presubmit_support.py", line 1091, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1006, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 128, in CheckChangeOnCommit
  File "<string>", line 45, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 890, in
PanProjectChecks
    input_api, output_api, source_file_filter=sources))
  File "/b/depot_tools/presubmit_canned_checks.py", line 743, in CheckOwners
    owners_db.email_regexp)
  File "/b/depot_tools/presubmit_canned_checks.py", line 767, in
_RietveldOwnerAndApprovers
    issue_props = input_api.rietveld.get_issue_properties(
AttributeError: 'NoneType' object has no attribute 'get_issue_properties'
Sending crash report ...
  exception: 'NoneType' object has no attribute 'get_issue_prop
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--author', 'binji@chromium.org', '--issue', '6982048', '--patchset', '6002',
'--name', '6982048-6002', '--description', 'Reset sync setup dialog to initial
state when it is opened.\n\nBUG=84542\nTEST=\n',
'chrome/browser/resources/options/sync_setup_overlay.html',
'chrome/browser/resources/options/sync_setup_overlay.css',
'chrome/browser/resources/options/sync_setup_overlay.js']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/chromium
A stack trace has been sent to the maintainers.

[M-A Ruel, 2011-06-03 18:45:25]

Fixed bug, reenabling commit bit.

[commit-bot: I haz the power, 2011-06-03 19:46:24]

Change committed as 87835

[James Hawkins, 2011-06-04 17:43:27]

It seems like we're only resetting the state of the login page; what about the
customize page?

http://codereview.chromium.org/6982048/diff/6002/chrome/browser/resources/opt...
File chrome/browser/resources/options/sync_setup_overlay.js (right):

http://codereview.chromium.org/6982048/diff/6002/chrome/browser/resources/opt...
chrome/browser/resources/options/sync_setup_overlay.js:547: resetPage_:
function(pageElementId) {
Add documentation for this method.

[binji, 2011-06-06 17:10:56]

On 2011/06/04 17:43:27, James Hawkins wrote:
> It seems like we're only resetting the state of the login page; what about the
> customize page?
That's in a separate patchset. http://codereview.chromium.org/7056059/

> Add documentation for this method.
OK, I'll add it to the other patchset.