Print Preview: Detecting plugin existence before generating the preview.

chrome/browser/ui/webui/print_preview_ui_html_source.cc

Index: chrome/browser/ui/webui/print_preview_ui_html_source.cc
diff --git a/chrome/browser/ui/webui/print_preview_ui_html_source.cc b/chrome/browser/ui/webui/print_preview_ui_html_source.cc
index be4b583b5190583bb94e9ab2cc247e53f21d8651..f23d87ad66c05bad3f2d787c2854a6a545d5a790 100644
--- a/chrome/browser/ui/webui/print_preview_ui_html_source.cc
+++ b/chrome/browser/ui/webui/print_preview_ui_html_source.cc
@@ -160,6 +160,11 @@ void PrintPreviewUIHTMLSource::StartDataRequest(const std::string& path,
       *it = *(preview_data + i);
     SendResponse(request_id, html_bytes);
     return;
+  } else if (path == "dummy.pdf") {

[vandebo (ex-Chrome), 2011/05/12 02:10:12]

It occurs to me that since the plugin doesn't need a valid PDF, we don't even
need this code.  The error page would be returned instead.

[Lei Zhang, 2011/05/12 02:19:34]

I would double check and make sure that doesn't crash the PDF viewer.

[dpapad, 2011/05/12 17:26:44]

Removed the "else if". As far as detecting the existence of the plugin it works.
Do we care if the dummy-plugin crashes? It is removed from the DOM tree right
after checking if it is compatible.

[Lei Zhang, 2011/05/12 17:50:45]

Well, if it crashes, then it is taking down the renderer with it, so we do care.
But it sounds like you tested it and that's not happening.

+    scoped_refptr<RefCountedStaticMemory> dummy_bytes(
+        new RefCountedStaticMemory());
+    SendResponse(request_id, dummy_bytes);
+    return;
   } else {
     // Invalid request.
     scoped_refptr<RefCountedBytes> empty_bytes(new RefCountedBytes);