chrome/browser/resources/print_preview.html - Issue 6982030: Print Preview: Detecting plugin existence before generating the preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview.html

Issue 6982030: Print Preview: Detecting plugin existence before generating the preview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/print_preview.html

diff --git a/chrome/browser/resources/print_preview.html b/chrome/browser/resources/print_preview.html

index e157a37e79157330e24c77d55b60da34e2113ab4..74286ef733c369a8943d3aedb0206929449f9fe3 100644

--- a/chrome/browser/resources/print_preview.html

+++ b/chrome/browser/resources/print_preview.html

@@ -122,5 +122,7 @@

</div>

+ <object id="dummy-viewer" type="application/pdf"

Lei Zhang 2011/05/11 20:27:43 does this need to be hidden?

dpapad 2011/05/11 22:08:20 I set it to hidden in the onLoad() method. Otherwi

+ src="chrome://print/blank.pdf"/>

</body>

</html>

« no previous file with comments | « no previous file | chrome/browser/resources/print_preview.js » ('j') | chrome/browser/resources/print_preview.js » ('J')