Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 6982011: Strip leading "javascript:" schemas from text pasted or dropped into the omnibox. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
===================================================================
--- chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (revision 85569)
+++ chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm (working copy)
@@ -1063,6 +1063,7 @@
ui::Clipboard::BUFFER_STANDARD)) {
string16 text16;
clipboard->ReadText(ui::Clipboard::BUFFER_STANDARD, &text16);
+ StripJavascriptSchema(text16, &text16);
// Note: Unlike in the find popup and textfield view, here we completely
// remove whitespace strings containing newlines. We assume users are
@@ -1083,11 +1084,13 @@
if (clipboard->IsFormatAvailable(ui::Clipboard::GetUrlWFormatType(),
ui::Clipboard::BUFFER_STANDARD)) {
std::string url_str;
+ string16 text;
clipboard->ReadBookmark(NULL, &url_str);
// pass resulting url string through GURL to normalize
GURL url(url_str);
if (url.is_valid()) {
- return UTF8ToUTF16(url.spec());
+ StripJavascriptSchema(UTF8ToUTF16(url.spec()), &text);
+ return text;
}
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('j') | chrome/browser/ui/omnibox/omnibox_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698