Strip leading "javascript:" schemas from text pasted or dropped into the omnibox.

chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
 #include <algorithm>
@@ skipping 639 matching lines @@
 
 void OmniboxViewGtk::OnRevertTemporaryText() {
   StartUpdatingHighlightedText();
   SetSelectedRange(saved_temporary_selection_);
   FinishUpdatingHighlightedText();
   TextChanged();
 }
 
 void OmniboxViewGtk::OnBeforePossibleChange() {
   // Record this paste, so we can do different behavior.
-  if (paste_clipboard_requested_) {
-    paste_clipboard_requested_ = false;
+  if (paste_clipboard_requested_)
     model_->on_paste();
-  }
 
   // This method will be called in HandleKeyPress() method just before
   // handling a key press event. So we should prevent it from being called
   // when handling the key press event.
   if (handling_key_press_)
     return;
 
   // Record our state.
   text_before_change_ = GetText();
   sel_before_change_ = GetSelection();
 #if GTK_CHECK_VERSION(2, 20, 0)
   pre_edit_size_before_change_ = pre_edit_.size();
 #endif
 }
 
 // TODO(deanm): This is mostly stolen from Windows, and will need some work.
 bool OmniboxViewGtk::OnAfterPossibleChange() {
   // This method will be called in HandleKeyPress() method just after
   // handling a key press event. So we should prevent it from being called
   // when handling the key press event.
   if (handling_key_press_) {
     content_maybe_changed_by_key_press_ = true;
     return false;
   }
 
+  if (paste_clipboard_requested_) {

[Peter Kasting, 2011/05/10 23:27:42]

I don't think this is the right place for this.  We should be doing this as part
of the process that actually gets the text off the clipboard.  I can't seem to
find where that is, though.  There's not currently a GetClipboardText() function
like on Mac and Windows.

[Cris Neckar, 2011/05/11 21:42:36]

The problem is that this is handled within the gtk control so there is no way to
check the content before the control text is changed. The callbacks for this are

1. A paste is about to occur
2. The control state will change when you return (OnBeforePossibleChange)
3. The text changes out of band
4. The control state just changed (OnAfterPossibleChange)

+    paste_clipboard_requested_ = false;
+    string16 text(GetText());
+    if (StripJavascriptSchema(text, &text))
+      SetUserText(text);
+  }
+
   // If the change is caused by an Enter key press event, and the event was not
   // handled by IME, then it's an unexpected change and shall be reverted here.
   // {Start|Finish}UpdatingHighlightedText() are called here to prevent the
   // PRIMARY selection from being changed.
   if (enter_was_pressed_ && enter_was_inserted_) {
     StartUpdatingHighlightedText();
     SetTextAndSelectedRange(text_before_change_, sel_before_change_);
     FinishUpdatingHighlightedText();
     return false;
   }
@@ skipping 872 matching lines @@
   // allow default behavior for such drags.
   if (context->source_window == text_view_->window)
     return;
 
   guchar* text = gtk_selection_data_get_text(selection_data);
   if (!text)
     return;
 
   string16 possible_url = UTF8ToUTF16(reinterpret_cast<char*>(text));
   g_free(text);
-  if (OnPerformDropImpl(possible_url)) {
+
+  string16 stripped_url(possible_url);
+  bool stripped = StripJavascriptSchema(stripped_url, &stripped_url);
+  if (OnPerformDropImpl(possible_url) || stripped) {
     gtk_drag_finish(context, TRUE, TRUE, time);
-
     static guint signal_id =
         g_signal_lookup("drag-data-received", GTK_TYPE_WIDGET);
     g_signal_stop_emission(text_view_, signal_id, 0);
+    if (stripped)
+      SetUserText(stripped_url);

[Peter Kasting, 2011/05/10 23:27:42]

Does GTK navigate on drop?  If so, where does that happen?  We're not preventing
any navigation here like we do on Mac/Win.

[Cris Neckar, 2011/05/11 21:42:36]

If the dragged text is a url it occurs in OnPerformDropImpl() by calling into
PasteAndGo()

When it is not a URL I am not sure. Looks like it would have to be in some
callback fired later but I don't see an AcceptInput() anywhere for it :/

   }
 }
 
 void OmniboxViewGtk::HandleDragDataGet(GtkWidget* widget,
                                        GdkDragContext* context,
                                        GtkSelectionData* selection_data,
                                        guint target_type,
                                        guint time) {
   DCHECK(text_view_);
   // If GTK put the normal textual version of the selection in our drag data,
@@ skipping 735 matching lines @@
   // baseline, so we need to move the |instant_view_| down to make sure it
   // has the same baseline as the |text_view_|.
   PangoLayout* layout = gtk_label_get_layout(GTK_LABEL(instant_view_));
   int height;
   pango_layout_get_size(layout, NULL, &height);
   PangoLayoutIter* iter = pango_layout_get_iter(layout);
   int baseline = pango_layout_iter_get_baseline(iter);
   pango_layout_iter_free(iter);
   g_object_set(instant_anchor_tag_, "rise", baseline - height, NULL);
 }