Strip leading "javascript:" schemas from text pasted or dropped into the omnibox.

chrome/browser/ui/omnibox/omnibox_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines the interface class OmniboxView.  Each toolkit will
 // implement the edit view differently, so that code is inherently platform
 // specific.  However, the AutocompleteEditModel needs to do some communication
 // with the view.  Since the model is shared between platforms, we need to
 // define an interface that all view implementations will share.
 
 #ifndef CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_H_
 #define CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_H_
 #pragma once
 
 #include <string>
 
 #include "base/string16.h"
+#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "content/common/page_transition_types.h"
+#include "content/common/url_constants.h"
 #include "ui/gfx/native_widget_types.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class AutocompleteEditModel;
 class CommandUpdater;
 class GURL;
 class TabContents;
 
 #if defined(TOOLKIT_VIEWS)
 namespace views {
@@ skipping 150 matching lines @@
   // returns the views::View of the edit view.
   virtual views::View* AddToView(views::View* parent) = 0;
 
   // Performs the drop of a drag and drop operation on the view.
   virtual int OnPerformDrop(const views::DropTargetEvent& event) = 0;
 #endif
 
   virtual ~OmniboxView() {}
 };
 
+// Strips any leading javascript schemas from a string.
+// Returns true if the output string differs from the input.
+static inline bool StripJavascriptSchema(const string16& text, string16* out) {

[Peter Kasting, 2011/05/20 22:04:14]

Nit: Don't do this inline.  It's not speed-critical.  Do it out-of-line in a .cc
file.

Also, I think if you make the signature "string16 StripJavascriptSchemas(const
string16&)", callers that don't care about checking for changes get simpler,
while callers that do care can check the new string length against the old in
about the same number of lines of code as they're using now.

Also, Schema -> Schemas.

[Cris Neckar, 2011/05/24 00:10:06]

Done.

+  const string16 kJsPrefix(UTF8ToUTF16(chrome::kJavaScriptScheme) +
+                           UTF8ToUTF16(":"));

[Peter Kasting, 2011/05/20 22:04:14]

Nit: I think both of these can be ASCIIToUTF16().

[Cris Neckar, 2011/05/24 00:10:06]

Done.

+  bool changed = false;
+  *out = text;

[Peter Kasting, 2011/05/20 22:04:14]

Nit: Shorter:

  for (*out = text; StartsWith(*out, kJsPrefix, false);
       TrimWhitespace(out->substr(kJsPrefix.length()), TRIM_LEADING, out))
    changed = true;

[Cris Neckar, 2011/05/24 00:10:06]

Done.

+  while (StartsWith(*out, kJsPrefix, false)) {
+    changed = true;
+    TrimWhitespace(out->substr(kJsPrefix.length()), TRIM_LEADING, out);
+  }
+  return changed;
+}
+
 #endif  // CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_H_