Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 6982010: GTK: Hardy build fix for r84860. (Closed)

Created:
9 years, 7 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Hardy build fix for r84860. (Aren't we supposed to be deprecating that?) BUG=30213 TEST=copmiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/ui/gtk/global_bookmark_menu.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
Need a quick stamp for a build fix for older Hardy.
9 years, 7 months ago (2011-05-10 22:02:39 UTC) #1
Evan Martin
LGTM
9 years, 7 months ago (2011-05-10 22:06:01 UTC) #2
Evan Martin
Wait a sec, is this a compile-time check?
9 years, 7 months ago (2011-05-10 22:06:27 UTC) #3
Elliot Glaysher
Yes. It has to be because the API I'm calling isn't in 2.12. On Tue, ...
9 years, 7 months ago (2011-05-10 22:07:03 UTC) #4
Evan Martin
On 2011/05/10 22:07:03, Elliot Glaysher wrote: > Yes. It has to be because the API ...
9 years, 7 months ago (2011-05-10 22:10:44 UTC) #5
Elliot Glaysher
On 2011/05/10 22:10:44, Evan Martin wrote: > On 2011/05/10 22:07:03, Elliot Glaysher wrote: > > ...
9 years, 7 months ago (2011-05-10 22:14:00 UTC) #6
Evan Martin
On 2011/05/10 22:14:00, Elliot Glaysher wrote: > On 2011/05/10 22:10:44, Evan Martin wrote: > > ...
9 years, 7 months ago (2011-05-10 22:25:49 UTC) #7
Elliot Glaysher
9 years, 7 months ago (2011-05-10 22:26:42 UTC) #8
Talked to thestig. We don't build on lucid yet, but that's the plan by
M13. I'll just dlsym it. sigh.

On Tue, May 10, 2011 at 3:14 PM,  <erg@chromium.org> wrote:
> On 2011/05/10 22:10:44, Evan Martin wrote:
>>
>> On 2011/05/10 22:07:03, Elliot Glaysher wrote:
>> > Yes. It has to be because the API I'm calling isn't in 2.12.
>
>> Won't that mean we always compile this out for all our binaries?
>
> Why? We build on Lucid now, right? The only compile problem I'm having is
> some
> memory bot.
>
> http://codereview.chromium.org/6982010/
>

Powered by Google App Engine
This is Rietveld 408576698