Added CHECK for tasks passed to PostTask being null.

Added CHECK for tasks passed to PostTask being null.

I hope this will make the crashes associated with posting null tasks fail fast so they can be more easily diagnosed.

TEST=try
BUG=none
TBR=darin@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84869

[awong, 2011-05-10 20:58:20]

[ +darin ]

LGTM

Darin, I think this is good tightening of the API, and am biasing towards
committing since it'll help apatrick track down a top crasher, and cause the
changes are really easy to back out.

-Albert


On Tue, May 10, 2011 at 1:47 PM, <apatrick@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Added CHECK for tasks passed to PostTask being null.
>
> I hope this will make the crashes associated with posting null tasks fail
> fast
> so they can be more easily diagnosed.
>
> TEST=try
> BUG=none
> TBR=darin@chromium.org
>
> Please review this at http://codereview.chromium.org/6982004/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/message_loop.cc
>
>
> Index: base/message_loop.cc
> ===================================================================
> --- base/message_loop.cc        (revision 84812)
> +++ base/message_loop.cc        (working copy)
> @@ -255,6 +255,7 @@
>
>  void MessageLoop::PostTask(
>     const tracked_objects::Location& from_here, Task* task) {
> +  CHECK(task);
>   PendingTask pending_task(
>       base::Bind(&TaskClosureAdapter::Run,
>                  new TaskClosureAdapter(task, &should_leak_tasks_)),
> @@ -265,6 +266,7 @@
>
>  void MessageLoop::PostDelayedTask(
>     const tracked_objects::Location& from_here, Task* task, int64 delay_ms)
> {
> +  CHECK(task);
>   PendingTask pending_task(
>       base::Bind(&TaskClosureAdapter::Run,
>                  new TaskClosureAdapter(task, &should_leak_tasks_)),
> @@ -275,6 +277,7 @@
>
>  void MessageLoop::PostNonNestableTask(
>     const tracked_objects::Location& from_here, Task* task) {
> +  CHECK(task);
>   PendingTask pending_task(
>       base::Bind(&TaskClosureAdapter::Run,
>                  new TaskClosureAdapter(task, &should_leak_tasks_)),
> @@ -285,6 +288,7 @@
>
>  void MessageLoop::PostNonNestableDelayedTask(
>     const tracked_objects::Location& from_here, Task* task, int64 delay_ms)
> {
> +  CHECK(task);
>   PendingTask pending_task(
>       base::Bind(&TaskClosureAdapter::Run,
>                  new TaskClosureAdapter(task, &should_leak_tasks_)),
> @@ -295,7 +299,7 @@
>
>  void MessageLoop::PostTask(
>     const tracked_objects::Location& from_here, const base::Closure& task)
> {
> -  DCHECK(!task.is_null());
> +  CHECK(!task.is_null());
>   PendingTask pending_task(task, from_here, CalculateDelayedRuntime(0),
> true);
>   AddToIncomingQueue(&pending_task);
>  }
> @@ -303,7 +307,7 @@
>  void MessageLoop::PostDelayedTask(
>     const tracked_objects::Location& from_here, const base::Closure& task,
>     int64 delay_ms) {
> -  DCHECK(!task.is_null());
> +  CHECK(!task.is_null());
>   PendingTask pending_task(task, from_here,
>                            CalculateDelayedRuntime(delay_ms), true);
>   AddToIncomingQueue(&pending_task);
> @@ -311,7 +315,7 @@
>
>  void MessageLoop::PostNonNestableTask(
>     const tracked_objects::Location& from_here, const base::Closure& task)
> {
> -  DCHECK(!task.is_null());
> +  CHECK(!task.is_null());
>   PendingTask pending_task(task, from_here, CalculateDelayedRuntime(0),
> false);
>   AddToIncomingQueue(&pending_task);
>  }
> @@ -319,7 +323,7 @@
>  void MessageLoop::PostNonNestableDelayedTask(
>     const tracked_objects::Location& from_here, const base::Closure& task,
>     int64 delay_ms) {
> -  DCHECK(!task.is_null());
> +  CHECK(!task.is_null());
>   PendingTask pending_task(task, from_here,
>                            CalculateDelayedRuntime(delay_ms), false);
>   AddToIncomingQueue(&pending_task);
>
>
>

[darin (slow to review), 2011-05-10 21:37:55]

LGTM